From: Sven Eckelmann <sven@narfation.org>
To: Marek Lindner <marek.lindner@mailbox.org>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <antonio@mandelbit.com>,
Matthias Schiffer <mschiffer@universe-factory.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH batadv 4/5] batman-adv: remove global hardif list
Date: Sun, 01 Jun 2025 15:36:44 +0200 [thread overview]
Message-ID: <2767731.Lt9SDvczpP@sven-l14> (raw)
In-Reply-To: <3742218.iIbC2pHGDl@sven-l14>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Sunday, 1 June 2025 15:10:50 CEST Sven Eckelmann wrote:
> So, even getting the parent (see `ASSERT_RTNL` in
> `netdev_master_upper_dev_get`) of the lower interface is a no-go at that
> point.
I didn't want to say here that this specific operation is necessary here. Just
wanted to point out that operating on these data structures might not always
be possible at that point. This is why I tried to point out that it might be
better to have something "good enough" using RCU which is managed outside this
context (write-only protected using rtnl_lock).
The idea of having something specific to meshif that still manages to detect
(beforehand) if there's a path to `batadv_interface_tx` - while `skb_iif`
remains set to a specific interface along the way - sounds like an
implementation nightmare to me.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-06-01 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 20:46 [PATCH batadv 1/5] batman-adv: store hard_iface as iflink private data Matthias Schiffer
2025-05-19 20:46 ` [PATCH batadv 2/5] batman-adv: only create hardif while a netdev is part of a mesh Matthias Schiffer
2025-05-31 9:16 ` Sven Eckelmann
2025-05-31 9:21 ` Sven Eckelmann
2025-05-31 9:52 ` Sven Eckelmann
2026-05-10 13:59 ` Sven Eckelmann
2025-05-19 20:46 ` [PATCH batadv 3/5] batman-adv: remove BATADV_IF_NOT_IN_USE hardif state Matthias Schiffer
2025-05-31 9:18 ` Sven Eckelmann
2025-05-19 20:46 ` [PATCH batadv 4/5] batman-adv: remove global hardif list Matthias Schiffer
2025-05-31 9:56 ` Sven Eckelmann
2025-06-01 9:26 ` Matthias Schiffer
2025-06-01 13:10 ` Sven Eckelmann
2025-06-01 13:36 ` Sven Eckelmann [this message]
2026-05-10 7:30 ` Sven Eckelmann
2025-05-19 20:46 ` [PATCH batadv 5/5] batman-adv: move hardif generation counter into batadv_priv Matthias Schiffer
2025-05-31 9:59 ` Sven Eckelmann
2025-05-31 8:31 ` [PATCH batadv 1/5] batman-adv: store hard_iface as iflink private data Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2767731.Lt9SDvczpP@sven-l14 \
--to=sven@narfation.org \
--cc=antonio@mandelbit.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.lindner@mailbox.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox