From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops
Date: Fri, 05 Jan 2018 09:43:59 +0100 [thread overview]
Message-ID: <14031954.75OLCfGoXO@sven-edge> (raw)
In-Reply-To: <1726572.H7yRIExqUN@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote:
> On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote:
> > It's somewhat common and in general a defect for c90 keywords to
> > not start on a tabstop.
> >
> > Add a test for this condition and warn when it occurs.
>
> This seems to create some new false positives:
>
> WARNING: Statements should start on a tabstop
> #919: FILE: ./net/batman-adv/sysfs.c:919:
> + char ifname[IFNAMSIZ])
>
> total: 0 errors, 1 warnings, 0 checks, 1251 lines checked
[...]
Grml, just noticed that I've replied to the wrong mail. This was of course introduced by
http://lkml.kernel.org/r/1b5f97673f36595956ad43329f77bf1a5546d2ff.1513976662.git.joe@perches.com
and not by this patch.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-01-05 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <609290bb4d6430ba6261347d43d53809a495afb9.1461267645.git.joe@perches.com>
2018-01-05 8:30 ` [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops Sven Eckelmann
2018-01-05 8:43 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14031954.75OLCfGoXO@sven-edge \
--to=sven@narfation.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox