* Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops [not found] <609290bb4d6430ba6261347d43d53809a495afb9.1461267645.git.joe@perches.com> @ 2018-01-05 8:30 ` Sven Eckelmann 2018-01-05 8:43 ` Sven Eckelmann 0 siblings, 1 reply; 2+ messages in thread From: Sven Eckelmann @ 2018-01-05 8:30 UTC (permalink / raw) To: Joe Perches; +Cc: Andrew Morton, Andy Whitcroft, linux-kernel, b.a.t.m.a.n [-- Attachment #1: Type: text/plain, Size: 1366 bytes --] On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > It's somewhat common and in general a defect for c90 keywords to > not start on a tabstop. > > Add a test for this condition and warn when it occurs. This seems to create some new false positives: WARNING: Statements should start on a tabstop #919: FILE: ./net/batman-adv/sysfs.c:919: + char ifname[IFNAMSIZ]) total: 0 errors, 1 warnings, 0 checks, 1251 lines checked The code at this position is: /** * batadv_store_mesh_iface_finish() - store new hardif mesh_iface state * @net_dev: netdevice to add/remove to/from batman-adv soft-interface * @ifname: name of soft-interface to modify * * Changes the parts of the hard+soft interface which can not be modified under * sysfs lock (to prevent deadlock situations). * * Return: 0 on success, 0 < on failure */ static int batadv_store_mesh_iface_finish(struct net_device *net_dev, char ifname[IFNAMSIZ]) { struct net *net = dev_net(net_dev); I know, my mail client is most likely mangling the tabs - so better check https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/net/batman-adv/sysfs.c?id=72deacce011bde7475c90e6ee7d4c7d28c384873#n918 Problem seems to be the [IFNAMSIZ] Kind regards, Sven [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops 2018-01-05 8:30 ` [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops Sven Eckelmann @ 2018-01-05 8:43 ` Sven Eckelmann 0 siblings, 0 replies; 2+ messages in thread From: Sven Eckelmann @ 2018-01-05 8:43 UTC (permalink / raw) To: b.a.t.m.a.n; +Cc: Joe Perches, Andy Whitcroft, Andrew Morton, linux-kernel [-- Attachment #1: Type: text/plain, Size: 817 bytes --] On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote: > On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote: > > It's somewhat common and in general a defect for c90 keywords to > > not start on a tabstop. > > > > Add a test for this condition and warn when it occurs. > > This seems to create some new false positives: > > WARNING: Statements should start on a tabstop > #919: FILE: ./net/batman-adv/sysfs.c:919: > + char ifname[IFNAMSIZ]) > > total: 0 errors, 1 warnings, 0 checks, 1251 lines checked [...] Grml, just noticed that I've replied to the wrong mail. This was of course introduced by http://lkml.kernel.org/r/1b5f97673f36595956ad43329f77bf1a5546d2ff.1513976662.git.joe@perches.com and not by this patch. Kind regards, Sven [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-05 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <609290bb4d6430ba6261347d43d53809a495afb9.1461267645.git.joe@perches.com>
2018-01-05 8:30 ` [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops Sven Eckelmann
2018-01-05 8:43 ` Sven Eckelmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox