[B.A.T.M.A.N.] batman-adv packet.h license

[B.A.T.M.A.N.] batman-adv packet.h license

[Andrew Lunn]

Hi Marek, Simon

I'm writing a protocol dissector for tcpdump which understands
batman-adv packets. To do this i need to use packet.h, at least that
is the easiest way to do it. tcpdump uses the BSD license, where as
packet.h is GPL2. So it is unlikely the tcpdump maintainers would
accept packet.h as is.

As the two copyright owners of this file, is it O.K. with you to if i
change the license on this one file in my tcpdump patch to use BSD?

       Thanks
          Andrew

Re: [B.A.T.M.A.N.] batman-adv packet.h license

[Simon Wunderlich]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Hello Andrew,

this is fine with me, let's hear what marek thinks. BTW, there are
excellent batman dissectors for wireshark, have you tried them already? 

best regards,
	Simon

On Mon, Aug 17, 2009 at 08:36:44PM +0200, Andrew Lunn wrote:
> Hi Marek, Simon
> 
> I'm writing a protocol dissector for tcpdump which understands
> batman-adv packets. To do this i need to use packet.h, at least that
> is the easiest way to do it. tcpdump uses the BSD license, where as
> packet.h is GPL2. So it is unlikely the tcpdump maintainers would
> accept packet.h as is.
> 
> As the two copyright owners of this file, is it O.K. with you to if i
> change the license on this one file in my tcpdump patch to use BSD?
> 
>        Thanks
>           Andrew
> _______________________________________________
> B.A.T.M.A.N mailing list
> B.A.T.M.A.N@lists.open-mesh.net
> https://lists.open-mesh.net/mm/listinfo/b.a.t.m.a.n
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [B.A.T.M.A.N.] batman-adv packet.h license

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

> Hello Andrew,
>
> this is fine with me, let's hear what marek thinks. BTW, there are
> excellent batman dissectors for wireshark, have you tried them already?
The B.A.T.M.A.N. dissector is in Wireshark 1.2, but the B.A.T.M.A.N. advanced 
dissector is still waiting in 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2631 and/or 
http://gitorious.org/wireshark-batman-plugins/wireshark-batman-adv

And I think that it is still a good idea to have tcpdump dissectors as you 
maybe want to have live output over your seriell interface on you embedded 
device without much hassle.

Best regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

Re: [B.A.T.M.A.N.] batman-adv packet.h license

[Andrew Lunn]

> And I think that it is still a good idea to have tcpdump dissectors as you 
> maybe want to have live output over your seriell interface on you embedded 
> device without much hassle.

Yes, that is my aim. Wireshark has too much overhead for embedded
system use.

Writing the dissector was simple. Writing new filters looks a lot
harder. I don't yet understand the Flex/Bision stuff in libpcap. Does
anybody have any experience with it?

        Andrew
        

Re: [B.A.T.M.A.N.] batman-adv packet.h license

[Marek Lindner]

Hey,

> this is fine with me, let's hear what marek thinks. 

yeah, also fine with me. Although I don't understand why we have to change the 
licence of our file for that (I never wrote dissectors for tcpdump).

Regards,
Marek

Re: [B.A.T.M.A.N.] batman-adv packet.h license

[Andrew Lunn]

> yeah, also fine with me. Although I don't understand why we have to
> change the licence of our file for that (I never wrote dissectors
> for tcpdump).

I'm directly using packet.h. As is, no changes. I need the packet
structure definitions. The file has a GPL header, so its licensed
under GPL. If you mix that file with the rest of tcpdump, which is
BSD, tcpdump becomes GPL. I'm guessing this is not acceptable. So for
the copy of packet.h i include in tcpdump, i want to put a BSD license
on the file. The version in the batman repository can stay GPL. 

Thanks for O.K.ing this. I will post a patch to tcpdump here for
testing, before sending it to the tcpdump maintainers.

         Andrew