From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use rx_handler_data pointer to store net_bridge_port pointer
Date: Thu, 17 Jun 2010 09:25:57 +0200 [thread overview]
Message-ID: <201006170925.59150.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <20100617054257.GA15420@lunn.ch>
[-- Attachment #1: Type: Text/Plain, Size: 734 bytes --]
Andrew Lunn wrote:
> > --- a/batman-adv-kernelland/hard-interface.h
> > +++ b/batman-adv-kernelland/hard-interface.h
> > @@ -38,3 +38,8 @@ int batman_skb_recv(struct sk_buff *skb,
> >
> > struct net_device *orig_dev);
> >
> > int hardif_min_mtu(void);
> > void update_min_mtu(void);
> >
> > +
> > +#ifndef netdev_isbridged
> > +#define netdev_isbridged(netdev) \
> > + ((net_dev)->priv_flags & IFF_BRIDGE_PORT)
> > +#endif
>
> Maybe this could be pushed upstream? Seems like a useful bit of code
> in general?
I don't think so. It is only used in ~7 places in the whole kernel. If you
want then please feel free to add something like this and submit it to David
S. Miller.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-06-17 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 22:39 [B.A.T.M.A.N.] [PATCH] batman-adv: use rx_handler_data pointer to store net_bridge_port pointer Sven Eckelmann
2010-06-16 22:42 ` Sven Eckelmann
2010-06-16 22:52 ` Marek Lindner
2010-06-16 23:10 ` Sven Eckelmann
2010-06-17 5:42 ` Andrew Lunn
2010-06-17 7:25 ` Sven Eckelmann [this message]
2010-06-17 8:57 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006170925.59150.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox