Re: [B.A.T.M.A.N.] PATCH fragmentation of unicast packets

[Sven Eckelmann <sven.eckelmann@gmx.de>]

[-- Attachment #1: Type: Text/Plain, Size: 1602 bytes --]

Andreas Langer wrote:
> If fragmentation is on, the mtu of the bat interface will be set to 1500
> and bigger packets will be splitted in two parts. The receiver stores the
> packets in a buffer list for each originator, which will be created with
> the first fragmented packet. For this handling i added a sequenznumber and
> the orig address to the unicast_packet definition.
> 
> regards,
> Andreas
> 
> Signed-off-by: Andreas Langer <an.langer at gmx.de>

This patch cannot be applied because the mailer added automatically wordwraps.
Either find a way to forbid such a behavior for your mailer or try to use
git-send-email. There are explanations how you do that can be found at
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt

And please try to check your patches with checkpatch.pl from the linux
sources. You will notice that you've removed a newline after the function
bat_set_rx_csum. This is important because we try to submit those patches to
the mainline linux kernel.

There are also other styling changes I don't understand. For example a newline
before create_neighbor. I haven't checked really more as I couldn't apply it.

And can you try to add [] around PATCH in the summary line and remove the
regards... stuff from the commits message? Otherwise it will be part of
the commit message and the patch we send to the kernel folks.

For more information please read
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches

Best regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]