[B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration

[B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration

[Sven Eckelmann]

The Makefile suggests to change it to enable or disable features. This resulted
in patch submissions with changed Makefile even when this change would not be
necessary.

Instead the configuration should be done using the make parameters explained in
README.external

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c6266a2..4d70e40 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@
 # 02110-1301, USA
 #
 
-# changing the CONFIG_* line to 'y' enables the related feature
+# read README.external for more information about the configuration
 # B.A.T.M.A.N. debugging:
 export CONFIG_BATMAN_ADV_DEBUG=n
 # B.A.T.M.A.N. bridge loop avoidance:
-- 
1.7.10.4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration

[Marek Lindner]

On Thursday, October 18, 2012 17:43:54 Sven Eckelmann wrote:
> The Makefile suggests to change it to enable or disable features. This
> resulted in patch submissions with changed Makefile even when this change
> would not be necessary.
> 
> Instead the configuration should be done using the make parameters
> explained in README.external
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 4e3c233.

Thanks,
Marek