public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't use call_rcu if not needed
Date: Mon, 6 May 2013 21:42:03 +0200	[thread overview]
Message-ID: <20130506194203.GK3773@ritirata.org> (raw)
In-Reply-To: <1367869192-3322-1-git-send-email-ordex@autistici.org>

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On Mon, May 06, 2013 at 09:39:52PM +0200, Antonio Quartulli wrote:
> batadv_tt_global_entry_free_ref uses call_rcu to schedule a
> function which will only free the global entry itself.
> 
> For this reason call_rcu is useless and kfree_rcu can be
> used to simplify the code.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>  compat.c            | 11 +++++++++++
>  translation-table.c | 20 ++++++--------------
>  2 files changed, 17 insertions(+), 14 deletions(-)
> 
> diff --git a/compat.c b/compat.c
> index 1f3a39d..6226f81 100644
> --- a/compat.c
> +++ b/compat.c
> @@ -27,6 +27,17 @@
>  
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 0, 0)

This compat code has not been tested because of lack of kernels...

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-05-06 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 19:39 [B.A.T.M.A.N.] [PATCH] batman-adv: don't use call_rcu if not needed Antonio Quartulli
2013-05-06 19:42 ` Antonio Quartulli [this message]
2013-05-06 20:29 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130506194203.GK3773@ritirata.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox