From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't use call_rcu if not needed
Date: Tue, 7 May 2013 04:29:46 +0800 [thread overview]
Message-ID: <201305070429.46317.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1367869192-3322-1-git-send-email-ordex@autistici.org>
On Tuesday, May 07, 2013 03:39:52 Antonio Quartulli wrote:
> +/**
> + * batadv_tt_global_entry_free_ref - decrement the refcounter for a
> + * tt_global_entry and possibly free it
> + * @tt_global_entry: the object to free
> + */
> static void
> batadv_tt_global_entry_free_ref(struct batadv_tt_global_entry
> *tt_global_entry) {
> if (atomic_dec_and_test(&tt_global_entry->common.refcount)) {
> batadv_tt_global_del_orig_list(tt_global_entry);
> - call_rcu(&tt_global_entry->common.rcu,
> - batadv_tt_global_entry_free_rcu);
> + kfree_rcu(tt_global_entry, common.rcu);
> }
> }
You are replacing 2 container_of() calls with a single one. If you are sure
that works why doesn't the compat code do that same ?
Cheers,
Marek
prev parent reply other threads:[~2013-05-06 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 19:39 [B.A.T.M.A.N.] [PATCH] batman-adv: don't use call_rcu if not needed Antonio Quartulli
2013-05-06 19:42 ` Antonio Quartulli
2013-05-06 20:29 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305070429.46317.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox