Re: [B.A.T.M.A.N.] [PATCH 03/10] alfred: Add netlink dependencies

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On Donnerstag, 21. Juli 2016 17:58:07 CEST Simon Wunderlich wrote:
> > diff --git a/vis/batman_adv.h b/vis/batman_adv.h
> > new file mode 120000
> > index 0000000..72222e9
> > --- /dev/null
> > +++ b/vis/batman_adv.h
> > @@ -0,0 +1 @@
> > +../batman_adv.h
> > \ No newline at end of file
> > diff --git a/vis/netlink.c b/vis/netlink.c
> > new file mode 120000
> > index 0000000..06d13cc
> > --- /dev/null
> > +++ b/vis/netlink.c
> > @@ -0,0 +1 @@
> > +../netlink.c
> > \ No newline at end of file
> > diff --git a/vis/netlink.h b/vis/netlink.h
> > new file mode 120000
> > index 0000000..c7a63b5
> > --- /dev/null
> > +++ b/vis/netlink.h
> > @@ -0,0 +1 @@
> > +../netlink.h
> > \ No newline at end of file
> 
> I was wondering why you use symlinks here, while we pull in the other
> headers from their original paths (../packet.h, ../list.h).
> 
> We should probably keep the header handling consistent. What would be your
> opinion whether we should use relative paths or symlinks?

This doesn't work for netlink.c because it would break during parallel builds. 
And netlink.c requires batman_adv.h which must be in the search path for it.

Possible would be to symlink netlink.c and netlink.h and Add "-I.." to 
CPPFLAGS of batadv-vis.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]