From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/10] alfred: Add netlink dependencies
Date: Thu, 21 Jul 2016 17:58:07 +0200 [thread overview]
Message-ID: <9358912.PbkjNdNDRZ@prime> (raw)
In-Reply-To: <1465152428-17299-3-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
> diff --git a/vis/batman_adv.h b/vis/batman_adv.h
> new file mode 120000
> index 0000000..72222e9
> --- /dev/null
> +++ b/vis/batman_adv.h
> @@ -0,0 +1 @@
> +../batman_adv.h
> \ No newline at end of file
> diff --git a/vis/netlink.c b/vis/netlink.c
> new file mode 120000
> index 0000000..06d13cc
> --- /dev/null
> +++ b/vis/netlink.c
> @@ -0,0 +1 @@
> +../netlink.c
> \ No newline at end of file
> diff --git a/vis/netlink.h b/vis/netlink.h
> new file mode 120000
> index 0000000..c7a63b5
> --- /dev/null
> +++ b/vis/netlink.h
> @@ -0,0 +1 @@
> +../netlink.h
> \ No newline at end of file
I was wondering why you use symlinks here, while we pull in the other headers
from their original paths (../packet.h, ../list.h).
We should probably keep the header handling consistent. What would be your
opinion whether we should use relative paths or symlinks?
Thanks,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-21 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 18:46 [B.A.T.M.A.N.] [PATCH 01/10] alfred: vis: Fix parsing of iface_status Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 02/10] alfred: Split list of objects in Makefile into separate lines Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 03/10] alfred: Add netlink dependencies Sven Eckelmann
2016-07-21 15:58 ` Simon Wunderlich [this message]
2016-07-21 16:01 ` Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 04/10] alfred: Add CAP_NET_ADMIN capabilities for netlink Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 05/10] alfred: Split translate_mac from debugfs backend Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 06/10] alfred: Translate mac addresses via netlink Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 07/10] alfred: Split get_tq from debugfs backend Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 08/10] alfred: Query TQ of originators via netlink Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 09/10] alfred: vis: Save device index in interface list Sven Eckelmann
2016-06-05 18:47 ` [B.A.T.M.A.N.] [PATCH 10/10] alfred: vis: Add support for netlink Sven Eckelmann
2016-07-16 7:28 ` [B.A.T.M.A.N.] [PATCH 11/11] alfred: Switch netlink uapi header copyright to ISC Sven Eckelmann
2016-07-26 11:55 ` [B.A.T.M.A.N.] [PATCH 01/10] alfred: vis: Fix parsing of iface_status Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9358912.PbkjNdNDRZ@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox