* Re: [B.A.T.M.A.N.] New Defects reported by Coverity Scan for batctl
[not found] <5aaf0fb1c41b_2bda2abf4cb1af68668dc@node1.mail>
@ 2018-03-20 1:09 ` Linus Lüssing
0 siblings, 0 replies; only message in thread
From: Linus Lüssing @ 2018-03-20 1:09 UTC (permalink / raw)
To: b.a.t.m.a.n
On Mon, Mar 19, 2018 at 01:17:37AM +0000, scan-admin@coverity.com wrote:
[...]
> ________________________________________________________________________________________________________
> *** CID 174547: Incorrect expression (COPY_PASTE_ERROR)
> /netlink.c: 255 in info_callback()
> 249 else
> 250 mcast_flags = -EOPNOTSUPP;
> 251
> 252 if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
> 253 mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
> 254 else
> >>> CID 174547: Incorrect expression (COPY_PASTE_ERROR)
> >>> "mcast_flags" in "mcast_flags = -95L" looks like a copy-paste error.
> 255 mcast_flags = -EOPNOTSUPP;
[...]
Now this is officially the second time a code/patch reviewing
algorithm creeps me out :D.
"Looks like", yeah... and even worse, the AI is actually right...
I will send a fix :).
Cheers
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-03-20 1:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5aaf0fb1c41b_2bda2abf4cb1af68668dc@node1.mail>
2018-03-20 1:09 ` [B.A.T.M.A.N.] New Defects reported by Coverity Scan for batctl Linus Lüssing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox