From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: [PATCH 12/12] batctl: netlink: use kernel-style error codes for nl_recvmsgs
Date: Wed, 08 Jul 2026 22:00:18 +0200 [thread overview]
Message-ID: <20260708-bugfixes-netlink-v1-12-8ce03e37f17b@narfation.org> (raw)
In-Reply-To: <20260708-bugfixes-netlink-v1-0-8ce03e37f17b@narfation.org>
When nl_recvmsgs() fails, it doesn't return a kernel/errno style error
codes. It is instead using negative NLE_* return codes. Since the rest of
the batctl code uses kernel style codes, just handle it as EIO error.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
functions.c | 2 +-
netlink.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/functions.c b/functions.c
index 213ba83..ba5ef83 100644
--- a/functions.c
+++ b/functions.c
@@ -565,7 +565,7 @@ int netlink_simple_request(struct nl_msg *msg)
err = 0;
ret = nl_recvmsgs(sock, cb);
if (ret < 0)
- err = ret;
+ err = -EIO;
err_free_cb:
nl_cb_put(cb);
diff --git a/netlink.c b/netlink.c
index 6e0d35a..fb6fdae 100644
--- a/netlink.c
+++ b/netlink.c
@@ -677,7 +677,8 @@ int netlink_query_common(struct state *state,
ret = nl_recvmsgs(state->sock, cb);
if (ret < 0) {
- query_opts->err = ret;
+ if (query_opts->err == 0)
+ query_opts->err = -EIO;
goto err_free_cb;
}
--
2.47.3
prev parent reply other threads:[~2026-07-08 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 20:00 [PATCH 00/12] batctl: netlink bugfixes Sven Eckelmann
2026-07-08 20:00 ` [PATCH 01/12] batctl: handle netlink callback object on error Sven Eckelmann
2026-07-08 20:00 ` [PATCH 02/12] batctl: netlink: abort netlink_print_common when message allocation fails Sven Eckelmann
2026-07-08 20:00 ` [PATCH 03/12] batctl: netlink: don't format NULL extra_info in info_callback Sven Eckelmann
2026-07-08 20:00 ` [PATCH 04/12] batctl: netlink: report dump errors signalled in the NLMSG_DONE message Sven Eckelmann
2026-07-08 20:00 ` [PATCH 05/12] batctl: netlink: detect receive errors in netlink_print_common Sven Eckelmann
2026-07-08 20:00 ` [PATCH 06/12] batctl: netlink: report kernel errors when writing settings Sven Eckelmann
2026-07-08 20:00 ` [PATCH 07/12] batctl: netlink: report send errors in netlink_simple_request Sven Eckelmann
2026-07-08 20:00 ` [PATCH 08/12] batctl: netlink: detect receive errors in query_rtnl_link Sven Eckelmann
2026-07-08 20:00 ` [PATCH 09/12] batctl: netlink: detect receive errors in netlink_simple_request Sven Eckelmann
2026-07-08 20:00 ` [PATCH 10/12] batctl: netlink: detect receive errors in query_rtnl_link_single Sven Eckelmann
2026-07-08 20:00 ` [PATCH 11/12] batctl: netlink: report error on query_rtnl_link send failure Sven Eckelmann
2026-07-08 20:00 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708-bugfixes-netlink-v1-12-8ce03e37f17b@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox