B.A.T.M.A.N Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: [PATCH 03/12] batctl: netlink: don't format NULL extra_info in info_callback
Date: Wed, 08 Jul 2026 22:00:09 +0200	[thread overview]
Message-ID: <20260708-bugfixes-netlink-v1-3-8ce03e37f17b@narfation.org> (raw)
In-Reply-To: <20260708-bugfixes-netlink-v1-0-8ce03e37f17b@narfation.org>

When asprintf() or strdup() fail to create the extra_info string,
info_callback() continues with extra_info set to NULL and passes it as
%s argument to the following asprintf(). Passing NULL to %s is
undefined behavior.

Fall back to an empty string when extra_info could not be allocated.

Fixes: d8dd1ff1a0fe ("batctl: Use netlink to replace some of debugfs")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 netlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/netlink.c b/netlink.c
index cb65655..dd0275e 100644
--- a/netlink.c
+++ b/netlink.c
@@ -440,7 +440,8 @@ static int info_callback(struct nl_msg *msg, void *arg)
 			       mesh_name,
 			       mesh_mac[0], mesh_mac[1], mesh_mac[2],
 			       mesh_mac[3], mesh_mac[4], mesh_mac[5],
-			       algo_name, extra_info, extra_header);
+			       algo_name, extra_info ? extra_info : "",
+			       extra_header);
 		if (ret < 0)
 			opts->remaining_header = NULL;
 

-- 
2.47.3


  parent reply	other threads:[~2026-07-08 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 20:00 [PATCH 00/12] batctl: netlink bugfixes Sven Eckelmann
2026-07-08 20:00 ` [PATCH 01/12] batctl: handle netlink callback object on error Sven Eckelmann
2026-07-08 20:00 ` [PATCH 02/12] batctl: netlink: abort netlink_print_common when message allocation fails Sven Eckelmann
2026-07-08 20:00 ` Sven Eckelmann [this message]
2026-07-08 20:00 ` [PATCH 04/12] batctl: netlink: report dump errors signalled in the NLMSG_DONE message Sven Eckelmann
2026-07-08 20:00 ` [PATCH 05/12] batctl: netlink: detect receive errors in netlink_print_common Sven Eckelmann
2026-07-08 20:00 ` [PATCH 06/12] batctl: netlink: report kernel errors when writing settings Sven Eckelmann
2026-07-08 20:00 ` [PATCH 07/12] batctl: netlink: report send errors in netlink_simple_request Sven Eckelmann
2026-07-08 20:00 ` [PATCH 08/12] batctl: netlink: detect receive errors in query_rtnl_link Sven Eckelmann
2026-07-08 20:00 ` [PATCH 09/12] batctl: netlink: detect receive errors in netlink_simple_request Sven Eckelmann
2026-07-08 20:00 ` [PATCH 10/12] batctl: netlink: detect receive errors in query_rtnl_link_single Sven Eckelmann
2026-07-08 20:00 ` [PATCH 11/12] batctl: netlink: report error on query_rtnl_link send failure Sven Eckelmann
2026-07-08 20:00 ` [PATCH 12/12] batctl: netlink: use kernel-style error codes for nl_recvmsgs Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708-bugfixes-netlink-v1-3-8ce03e37f17b@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox