* [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state
@ 2018-03-20 1:19 Linus Lüssing
2018-03-20 7:11 ` Sven Eckelmann
0 siblings, 1 reply; 2+ messages in thread
From: Linus Lüssing @ 2018-03-20 1:19 UTC (permalink / raw)
To: b.a.t.m.a.n
This fixes a copy & paste error detected by Coverity.
Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table")
Reported-by: scan-admin@coverity.com
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink.c b/netlink.c
index ab7be1e..f0fd1d9 100644
--- a/netlink.c
+++ b/netlink.c
@@ -252,7 +252,7 @@ static int info_callback(struct nl_msg *msg, void *arg)
if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
else
- mcast_flags = -EOPNOTSUPP;
+ mcast_flags_priv = -EOPNOTSUPP;
switch (opts->nl_cmd) {
case BATADV_CMD_GET_TRANSTABLE_LOCAL:
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state
2018-03-20 1:19 [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state Linus Lüssing
@ 2018-03-20 7:11 ` Sven Eckelmann
0 siblings, 0 replies; 2+ messages in thread
From: Sven Eckelmann @ 2018-03-20 7:11 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Dienstag, 20. März 2018 02:19:24 CET Linus Lüssing wrote:
> This fixes a copy & paste error detected by Coverity.
>
> Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table")
> Reported-by: scan-admin@coverity.com
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied as 15f6d90 [1].
Thanks,
Sven
[1] https://git.open-mesh.org/batctl.git/commit/15f6d908fe3d152fc7a4c682231d13fbf1b8751e
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-20 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-20 1:19 [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state Linus Lüssing
2018-03-20 7:11 ` Sven Eckelmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox