[PATCH] bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command

[PATCH] bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command

[Richard Purdie]

When running bitbake in -k mode, the last command might succeed but we
still need to preserve any previous failure codes.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 63b8dc6..7a2681d 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -188,7 +188,8 @@ def main(server, eventHandler):
                 logger.error("Command execution failed: %s", event.error)
                 break
             if isinstance(event, bb.command.CommandExit):
-                return_value = event.exitcode
+                if not return_value:
+                    return_value = event.exitcode
                 continue
             if isinstance(event, bb.cooker.CookerExit):
                 break

Re: [PATCH] bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command

[Joshua Lock]

On Tue, 2011-08-09 at 14:42 +0100, Richard Purdie wrote:
> When running bitbake in -k mode, the last command might succeed but we
> still need to preserve any previous failure codes.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Signed-off-by: Joshua Lock <josh@linux.intel.com>

> ---
> diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
> index 63b8dc6..7a2681d 100644
> --- a/bitbake/lib/bb/ui/knotty.py
> +++ b/bitbake/lib/bb/ui/knotty.py
> @@ -188,7 +188,8 @@ def main(server, eventHandler):
>                  logger.error("Command execution failed: %s", event.error)
>                  break
>              if isinstance(event, bb.command.CommandExit):
> -                return_value = event.exitcode
> +                if not return_value:
> +                    return_value = event.exitcode
>                  continue
>              if isinstance(event, bb.cooker.CookerExit):
>                  break
> 
> 
> 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre