* [PATCH] git.py: Remove -l option, its not necessary
@ 2012-06-22 11:52 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2012-06-22 11:52 UTC (permalink / raw)
To: bitbake-devel
If -l is specified and the source and destination are not on a common
filesystem an error occurs. The -l option is however the default for
git for local paths which the fetcher already now ensures in the
file:// case.
We can therefore safely drop the -l option.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 07d722a..1c9a01c 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -188,9 +188,10 @@ class Git(FetchMethod):
# If the repo still doesn't exist, fallback to cloning it
if not os.path.exists(ud.clonedir):
+ # We do this since git will use a "-l" option automatically for local urls where possible
if repourl.startswith("file://"):
repourl = repourl[7:]
- clone_cmd = "%s clone -l --bare --mirror %s %s" % (ud.basecmd, repourl, ud.clonedir)
+ clone_cmd = "%s clone --bare --mirror %s %s" % (ud.basecmd, repourl, ud.clonedir)
if ud.proto.lower() != 'file':
bb.fetch2.check_network_access(d, clone_cmd)
runfetchcmd(clone_cmd, d)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-22 12:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-22 11:52 [PATCH] git.py: Remove -l option, its not necessary Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox