* [PATCH] cooker: fix traceback when using -b with skipped recipe
@ 2012-08-22 15:14 Paul Eggleton
2012-08-23 7:50 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2012-08-22 15:14 UTC (permalink / raw)
To: bitbake-devel
If a recipe is skipped during parsing for whatever reason, check and
report this as an error rather than trying to use the data that is sent
back and failing.
Fixes [YOCTO #2976].
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
bitbake/lib/bb/cooker.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 1737e54..a6b848e 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -1060,6 +1060,10 @@ class BBCooker:
info_array = infos[fn]
except KeyError:
bb.fatal("%s does not exist" % fn)
+
+ if info_array[0].skipped:
+ bb.fatal("%s was skipped: %s" % (fn, info_array[0].skipreason))
+
self.status.add_from_recipeinfo(fn, info_array)
# Tweak some variables
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cooker: fix traceback when using -b with skipped recipe
2012-08-22 15:14 [PATCH] cooker: fix traceback when using -b with skipped recipe Paul Eggleton
@ 2012-08-23 7:50 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-08-23 7:50 UTC (permalink / raw)
To: Paul Eggleton; +Cc: bitbake-devel
On Wed, 2012-08-22 at 16:14 +0100, Paul Eggleton wrote:
> If a recipe is skipped during parsing for whatever reason, check and
> report this as an error rather than trying to use the data that is sent
> back and failing.
>
> Fixes [YOCTO #2976].
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> bitbake/lib/bb/cooker.py | 4 ++++
> 1 file changed, 4 insertions(+)
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 15:14 [PATCH] cooker: fix traceback when using -b with skipped recipe Paul Eggleton
2012-08-23 7:50 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox