Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [PATCH] wget: Only use -O option when not spidering
@ 2013-02-14 21:33 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2013-02-14 21:33 UTC (permalink / raw)
  To: bitbake-devel

If we pass the -O option whilst spidering, empty files are created which is not
desired. We also need to ensure any subdirectories are created when using the
downloadfilename parameter.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/fetch2/wget.py b/bitbake/lib/bb/fetch2/wget.py
index 2808df6..24eec31 100644
--- a/bitbake/lib/bb/fetch2/wget.py
+++ b/bitbake/lib/bb/fetch2/wget.py
@@ -65,7 +65,8 @@ class Wget(FetchMethod):
 
         basecmd = d.getVar("FETCHCMD_wget", True) or "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --no-check-certificate"
 
-        if 'downloadfilename' in ud.parm:
+        if not checkonly and 'downloadfilename' in ud.parm:
+            bb.utils.mkdirhier(os.path.dirname(ud.localfile))
             basecmd += " -O ${DL_DIR}/" + ud.localfile
 
         if checkonly:





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-02-14 21:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-14 21:33 [PATCH] wget: Only use -O option when not spidering Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox