* [PATCH] codeparser: Drop unneeded variable separation
@ 2013-11-25 23:00 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2013-11-25 23:00 UTC (permalink / raw)
To: bitbake-devel
There is no good reason to separately track var_references and
references so merge them and remove the unneeded variable.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/lib/bb/codeparser.py b/bitbake/lib/bb/codeparser.py
index e44e791..1164815 100644
--- a/bitbake/lib/bb/codeparser.py
+++ b/bitbake/lib/bb/codeparser.py
@@ -122,7 +122,7 @@ class PythonParser():
name = self.called_node_name(node.func)
if name in self.getvars or name in self.containsfuncs:
if isinstance(node.args[0], ast.Str):
- self.var_references.add(node.args[0].s)
+ self.references.add(node.args[0].s)
else:
self.warn(node.func, node.args[0])
elif name in self.execfuncs:
@@ -147,7 +147,6 @@ class PythonParser():
break
def __init__(self, name, log):
- self.var_references = set()
self.var_execs = set()
self.execs = set()
self.references = set()
@@ -177,7 +176,6 @@ class PythonParser():
if n.__class__.__name__ == "Call":
self.visit_Call(n)
- self.references.update(self.var_references)
self.references.update(self.var_execs)
codeparsercache.pythoncacheextras[h] = {}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-25 23:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 23:00 [PATCH] codeparser: Drop unneeded variable separation Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox