* [PATCH] process: Deal with infinite looping of the server
@ 2014-08-20 22:40 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2014-08-20 22:40 UTC (permalink / raw)
To: bitbake-devel
Currently if an exception occurs, we just run the idle handler again and
again, usually looping indefinitely. Chances are the exception that occurred
will keep occurring and this is not a good place to be.
This was breaking the autobuilders with gigabytes of logs.
At least improve things so the cooker shuts down gracefully when this happens.
Some trace of the original problem may still be present on the console too!
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/server/process.py b/bitbake/lib/bb/server/process.py
index a0bcbfa..7fdf964 100644
--- a/bitbake/lib/bb/server/process.py
+++ b/bitbake/lib/bb/server/process.py
@@ -139,6 +139,8 @@ class ProcessServer(Process, BaseImplServer):
raise
except Exception:
logger.exception('Running idle function')
+ del self._idlefuns[function]
+ self.quit = True
if nextsleep is not None:
select.select(fds,[],[],nextsleep)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-20 22:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 22:40 [PATCH] process: Deal with infinite looping of the server Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox