Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Cristiana Voicu <cristiana.voicu@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH_V2 03/16] hob/bitbake: create a template (a .bb file) from hob through bitbake
Date: Fri, 26 Jul 2013 15:22:29 +0100	[thread overview]
Message-ID: <1411340.q3cuRxE77r@helios> (raw)
In-Reply-To: <1374752549-29471-4-git-send-email-cristiana.voicu@intel.com>

Hi Cristiana,

On Thursday 25 July 2013 14:42:16 Cristiana Voicu wrote:
> diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
> index 49e6345..7d54ab1 100644
> --- a/bitbake/lib/bb/cooker.py
> +++ b/bitbake/lib/bb/cooker.py
> @@ -1100,16 +1100,29 @@ class BBCooker:
>  
>          self.configuration.server_register_idlecallback(buildTargetsIdle,
> rq) 
> -    def generateNewImage(self, image, base_image, package_queue):
> +    def ensureDir(self, d):
> +        if not os.path.exists(d):
> +            os.makedirs(d)

Could you use bb.utils.mkdirhier() rather than creating an additional function 
to do the same thing?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2013-07-26 14:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 11:42 [PATCH_V2 00/16] bitbake+hob: templates enhancement Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 01/16] hob: labelling changes in Hob Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 02/16] hob: create save image dialog used to save a template Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 03/16] hob/bitbake: create a template (a .bb file) from hob through bitbake Cristiana Voicu
2013-07-26 14:22   ` Paul Eggleton [this message]
2013-07-25 11:42 ` [PATCH_V2 04/16] hob/bitbake: save the description of a custom image Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 05/16] hob: make changes in order to permit from UI to edit an image after saving it Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 06/16] hob & bitbake: append a value to a variable from hob throught bitbake Cristiana Voicu
2013-07-26 14:21   ` Paul Eggleton
2013-07-26 14:35     ` Voicu, Cristiana
2013-07-26 15:01       ` Paul Eggleton
2013-07-25 11:42 ` [PATCH_V2 07/16] hob: change the name and description for the saveimagedialog Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 08/16] hob: the saved image should be editable Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 09/16] hob/bitbake: when an image is saved, it should require an image from layers Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 10/16] hob: changes to image combo box Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 11/16] hob: retrieve file name of an image Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 12/16] hob: implement the "retrieve image dialog" + changes to image combo box Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 13/16] bitbake: save packages in IMAGE_INSTALL instead of PACKAGE_INSTALL Cristiana Voicu
2013-07-26 14:22   ` Paul Eggleton
2013-07-26 14:48     ` Voicu, Cristiana
2013-07-26 15:05       ` Paul Eggleton
2013-07-26 15:10         ` Voicu, Cristiana
2013-07-25 11:42 ` [PATCH_V2 14/16] hob: set focus on entry name when the name is not correct Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 15/16] hob/imagedetailspage: add tooltip for save image recipe button Cristiana Voicu
2013-07-25 11:42 ` [PATCH_V2 16/16] hob/imageconfigurationpage: changes to image combobox Cristiana Voicu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411340.q3cuRxE77r@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=cristiana.voicu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox