Re: [PATCH_V2 13/16] bitbake: save packages in IMAGE_INSTALL instead of PACKAGE_INSTALL

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Cristiana,

On Thursday 25 July 2013 14:42:26 Cristiana Voicu wrote:
> Hob retrieves the list of recipes and packages using the IMAGE_INSTALL
> variable, so a custom image should be saved using this variable.
> Changed how the image is saved in a bb file
> 
> [YOCTO #4193]
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/cooker.py |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
> index ad92dea..48be434 100644
> --- a/bitbake/lib/bb/cooker.py
> +++ b/bitbake/lib/bb/cooker.py
> @@ -1159,11 +1159,11 @@ class BBCooker:
>                  if topdir in base_image:
>                      base_image = require_line.split()[1]
>                  imagefile.write("require " + base_image + "\n")
> -            package_install = "PACKAGE_INSTALL_forcevariable = \""
> +            image_install = "IMAGE_INSTALL_append = \""
>              for package in package_queue:
> -                package_install += str(package) + " "
> -            package_install += "\"\n"
> -            imagefile.write(package_install)
> +                image_install += str(package) + " "
> +            image_install += "\"\n"
> +            imagefile.write(image_install)
> 
>              description_var = "DESCRIPTION = \"" + description + "\"\n"
>              imagefile.write(description_var)

If this is within the image recipe it should be using IMAGE_INSTALL = rather 
than appending to an existing value. At the moment it looks like you're using 
_append with no leading space which could interact poorly with any previous 
value set, and in any case I'm not entirely sure we need to support having a 
previous value in there within this context.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre