From: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH v2] fetcher: fix BB_STRICT_CHECKSUM datatype check
Date: Tue, 30 Sep 2014 11:21:58 -0500 [thread overview]
Message-ID: <1412094118-27406-1-git-send-email-alejandro.hernandez@linux.intel.com> (raw)
Forcing strict to be a string, to avoid problems when performing comparisons
[YOCTO #6762]
Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
---
lib/bb/fetch2/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index df2f2b0..10c3346 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -543,8 +543,8 @@ def verify_checksum(ud, d):
if ud.method.recommends_checksum(ud):
# If strict checking enabled and neither sum defined, raise error
- strict = d.getVar("BB_STRICT_CHECKSUM", True) or None
- if strict and not (ud.md5_expected or ud.sha256_expected):
+ strict = d.getVar("BB_STRICT_CHECKSUM", "1") or "0"
+ if (strict == "1") and not (ud.md5_expected or ud.sha256_expected):
logger.error('No checksum specified for %s, please add at least one to the recipe:\n'
'SRC_URI[%s] = "%s"\nSRC_URI[%s] = "%s"' %
(ud.localpath, ud.md5_name, md5data,
--
1.9.1
next reply other threads:[~2014-09-30 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:21 Alejandro Hernandez [this message]
2014-10-08 16:13 ` [PATCH v2] fetcher: fix BB_STRICT_CHECKSUM datatype check Christopher Larson
2014-10-09 20:22 ` Alejandro Hernandez
2014-10-09 20:27 ` Christopher Larson
2014-10-09 20:38 ` Alejandro Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412094118-27406-1-git-send-email-alejandro.hernandez@linux.intel.com \
--to=alejandro.hernandez@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox