Openembedded Bitbake Development
 help / color / mirror / Atom feed
From: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: "bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH v2] fetcher: fix BB_STRICT_CHECKSUM datatype check
Date: Thu, 09 Oct 2014 15:38:54 -0500	[thread overview]
Message-ID: <5436F25E.7080205@linux.intel.com> (raw)
In-Reply-To: <CABcZANnpRcOBo7wSoVoHh3P7KB717LoJ9UySKE0TPiEh-cthkQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

That is very true, I will fix that, thanks for pointing it out.

On 09/10/14 15:27, Christopher Larson wrote:
>
> On Thu, Oct 9, 2014 at 1:22 PM, Alejandro Hernandez 
> <alejandro.hernandez@linux.intel.com 
> <mailto:alejandro.hernandez@linux.intel.com>> wrote:
>
>     It does not change behavior but it forces the value to be a
>     string, avoiding related problems when performing comparisons on
>     "strict", another option as Richard Purdie suggested would be to
>     import the boolean function from /meta/lib/oe/types.py in OE-Core
>     into a new types module in bitbake, forcing it to get a "good"
>     value that we could then use.
>
>
> No, that's incorrect. The second argument of getVar is a boolean 
> argument named 'expand', which controls whether you get an expanded or 
> unexpanded value. You're now passing a string in boolean context.
> -- 
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics


[-- Attachment #2: Type: text/html, Size: 2048 bytes --]

      reply	other threads:[~2014-10-09 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 16:21 [PATCH v2] fetcher: fix BB_STRICT_CHECKSUM datatype check Alejandro Hernandez
2014-10-08 16:13 ` Christopher Larson
2014-10-09 20:22   ` Alejandro Hernandez
2014-10-09 20:27     ` Christopher Larson
2014-10-09 20:38       ` Alejandro Hernandez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5436F25E.7080205@linux.intel.com \
    --to=alejandro.hernandez@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=clarson@kergoth.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox