Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [PATCH] data: Handle BASH_FUNC shellshock implication
@ 2014-12-08 16:37 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2014-12-08 16:37 UTC (permalink / raw)
  To: bitbake-devel

The shellshock patches changed the way bash functions are exported.
Unfortunately different distros used slightly different formats,
Fedora went with BASH_FUNC_XXX()=() { echo foo; } and Ubuntu went with
BASH_FUNC_foo%%=() {  echo foo; }.

The former causes errors in dealing with out output from emit_env,
the functions are not exported in either case any more.

This patch handles things so the functions work as expected in either
case.

[YOCTO #6880]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py
index 91b1eb1..eb628c7 100644
--- a/bitbake/lib/bb/data.py
+++ b/bitbake/lib/bb/data.py
@@ -219,6 +219,13 @@ def emit_var(var, o=sys.__stdout__, d = init(), all=False):
 
     val = str(val)
 
+    if varExpanded.startswith("BASH_FUNC_"):
+        varExpanded = varExpanded[10:-2]
+        val = val[3:] # Strip off "() "
+        o.write("%s() %s\n" % (varExpanded, val))
+        o.write("export -f %s\n" % (varExpanded))
+        return 1
+
     if func:
         # NOTE: should probably check for unbalanced {} within the var
         o.write("%s() {\n%s\n}\n" % (varExpanded, val))




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-12-08 16:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 16:37 [PATCH] data: Handle BASH_FUNC shellshock implication Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox