* [PATCH] cooker: Further optimise pyinotify
@ 2015-01-21 11:16 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-01-21 11:16 UTC (permalink / raw)
To: bitbake-devel
We currently add crazy numbers of watches on files. The per user limit is 8192
by default and on a system handling multiple builds, this can be an issue.
We don't need to watch all files individually, we can watch the directory containing
the file instead. This gives better resource utilisation and better performance
further reverting some of the performance regression seen with the introduction
of pyinotify.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 9086f92..554dfbd 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -182,7 +182,7 @@ class BBCooker:
if not watcher:
watcher = self.watcher
for i in deps:
- f = i[0]
+ f = os.path.dirname(i[0])
if f in watcher.bbseen:
continue
watcher.bbseen.append(f)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-21 11:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-21 11:16 [PATCH] cooker: Further optimise pyinotify Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox