* [PATCH] server/process: Don't log BBHandledException
@ 2015-06-19 11:26 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-06-19 11:26 UTC (permalink / raw)
To: bitbake-devel
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
If we see a BBHandledException in the idle handler, the understanding
is the system handled it, printing a log and traceback is just confusing.
Therefore only print these in the cases where its an unknown/unhandled
exception.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/server/process.py b/bitbake/lib/bb/server/process.py
index c9286dd..ef3ee57 100644
--- a/bitbake/lib/bb/server/process.py
+++ b/bitbake/lib/bb/server/process.py
@@ -144,8 +144,9 @@ class ProcessServer(Process, BaseImplServer):
fds = fds + retval
except SystemExit:
raise
- except Exception:
- logger.exception('Running idle function')
+ except Exception as exc:
+ if not isinstance(exc, bb.BBHandledException):
+ logger.exception('Running idle function')
del self._idlefuns[function]
self.quit = True
[-- Attachment #2: Type: text/html, Size: 1267 bytes --]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-19 11:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-19 11:26 [PATCH] server/process: Don't log BBHandledException Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox