Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [PATCH] data_smart: Separate out update_overridevars into separate function
@ 2015-09-16 20:54 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-09-16 20:54 UTC (permalink / raw)
  To: bitbake-devel

No code changes, just refactoring to allow for functionality 
changes by moving things to a separate function.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
index 6754e7d..f245d99 100644
--- a/bitbake/lib/bb/data_smart.py
+++ b/bitbake/lib/bb/data_smart.py
@@ -491,10 +491,8 @@ class DataSmart(MutableMapping):
             if '_' in var:
                 self._setvar_update_overrides(base, **loginfo)
 
-
             if base in self.overridevars:
-                self.overridevars.update(self.expandWithRefs(value, var).references)
-                self.internal_finalize(True)
+                self._setvar_update_overridevars(var, value)
             return
 
         if not var in self.dict:
@@ -527,8 +525,11 @@ class DataSmart(MutableMapping):
         self.varhistory.record(**loginfo)
 
         if var in self.overridevars:
-            self.overridevars.update(self.expandWithRefs(value, var).references)
-            self.internal_finalize(True)
+            self._setvar_update_overridevars(var, value)
+
+    def _setvar_update_overridevars(self, var, value):
+        self.overridevars.update(self.expandWithRefs(value, var).references)
+        self.internal_finalize(True)
 
     def _setvar_update_overrides(self, var, **loginfo):
         # aka pay the cookie monster




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-16 20:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 20:54 [PATCH] data_smart: Separate out update_overridevars into separate function Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox