* [PATCH 0/1] hob2: add elf to image types @ 2012-07-17 6:58 Kang Kai 2012-07-17 6:58 ` [PATCH 1/1] hob2: add elf to hcc supported " Kang Kai 0 siblings, 1 reply; 6+ messages in thread From: Kang Kai @ 2012-07-17 6:58 UTC (permalink / raw) To: bitbake-devel; +Cc: Zhenfeng.Zhao Fixes Yocto #2709 The following changes since commit eb0cb7e8234f5d2e5623406e9660be91cf52f65e: perf: add perl, python to DEPENDS (2012-07-12 12:52:09 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib kangkai/distro http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro Kang Kai (1): hob2: add elf to hcc supported image types bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- 1.7.5.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] hob2: add elf to hcc supported image types 2012-07-17 6:58 [PATCH 0/1] hob2: add elf to image types Kang Kai @ 2012-07-17 6:58 ` Kang Kai 2012-07-17 9:52 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Kang Kai @ 2012-07-17 6:58 UTC (permalink / raw) To: bitbake-devel; +Cc: Zhenfeng.Zhao [Yocto #2709] OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed. Add elf to hcc supoorted image types to fix this issue. Signed-off-by: Kang Kai <kai.kang@windriver.com> --- bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py index dba278c..d10c56b 100644 --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py @@ -89,6 +89,7 @@ class hcc: "cpio.xz" : ["cpio.xz"], "vmdk" : ["vmdk"], "cpio.lzma" : ["cpio.lzma"], + "elf" : ["elf"], } class HobViewTable (gtk.VBox): -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] hob2: add elf to hcc supported image types 2012-07-17 6:58 ` [PATCH 1/1] hob2: add elf to hcc supported " Kang Kai @ 2012-07-17 9:52 ` Richard Purdie 2012-07-18 3:13 ` Kang Kai 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2012-07-17 9:52 UTC (permalink / raw) To: Kang Kai; +Cc: bitbake-devel, Zhenfeng.Zhao On Tue, 2012-07-17 at 14:58 +0800, Kang Kai wrote: > [Yocto #2709] > > OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image > type. This will cause hob build image failed. > Add elf to hcc supoorted image types to fix this issue. > > Signed-off-by: Kang Kai <kai.kang@windriver.com> > --- > bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py > index dba278c..d10c56b 100644 > --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py > +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py > @@ -89,6 +89,7 @@ class hcc: > "cpio.xz" : ["cpio.xz"], > "vmdk" : ["vmdk"], > "cpio.lzma" : ["cpio.lzma"], > + "elf" : ["elf"], > } > > class HobViewTable (gtk.VBox): Why do we have a hardcoded list here and why do new image types cause builds to fail? We need to rewrite this code so this does not happen and the user at least gets a sensible error message. Hardcoded lists are bad... I've merged the patch but I'd like to see a bug opened about this. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] hob2: add elf to hcc supported image types 2012-07-17 9:52 ` Richard Purdie @ 2012-07-18 3:13 ` Kang Kai 2012-07-18 13:15 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Kang Kai @ 2012-07-18 3:13 UTC (permalink / raw) To: Richard Purdie; +Cc: bitbake-devel, Zhenfeng.Zhao On 2012年07月17日 17:52, Richard Purdie wrote: > On Tue, 2012-07-17 at 14:58 +0800, Kang Kai wrote: >> [Yocto #2709] >> >> OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image >> type. This will cause hob build image failed. >> Add elf to hcc supoorted image types to fix this issue. >> >> Signed-off-by: Kang Kai<kai.kang@windriver.com> >> --- >> bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py >> index dba278c..d10c56b 100644 >> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py >> +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py >> @@ -89,6 +89,7 @@ class hcc: >> "cpio.xz" : ["cpio.xz"], >> "vmdk" : ["vmdk"], >> "cpio.lzma" : ["cpio.lzma"], >> + "elf" : ["elf"], >> } >> >> class HobViewTable (gtk.VBox): Hi Richard, Thanks. > Why do we have a hardcoded list here and why do new image types cause > builds to fail? After build the image, Hob trys to get list of created images. It needs a map from image type to real image file's extend name, such as "live" --> "hddimg" and "iso". then search the image output dir to get the list. > > We need to rewrite this code so this does not happen and the user at > least gets a sensible error message. Hardcoded lists are bad... For the current, only image type 'live' need this map. So I can remove the list and check the image type is whether 'live' or not. But for the future, if a new image type added and need this kind of map, new check for the single type is needed. I think for this scenario the list is better. Regards, Kai > > I've merged the patch but I'd like to see a bug opened about this. > > Cheers, > > Richard > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] hob2: add elf to hcc supported image types 2012-07-18 3:13 ` Kang Kai @ 2012-07-18 13:15 ` Richard Purdie 2012-07-19 3:16 ` Kang Kai 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2012-07-18 13:15 UTC (permalink / raw) To: Kang Kai; +Cc: bitbake-devel, Zhenfeng.Zhao On Wed, 2012-07-18 at 11:13 +0800, Kang Kai wrote: > On 2012年07月17日 17:52, Richard Purdie wrote: > > On Tue, 2012-07-17 at 14:58 +0800, Kang Kai wrote: > >> [Yocto #2709] > >> > >> OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image > >> type. This will cause hob build image failed. > >> Add elf to hcc supoorted image types to fix this issue. > >> > >> Signed-off-by: Kang Kai<kai.kang@windriver.com> > >> --- > >> bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py > >> index dba278c..d10c56b 100644 > >> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py > >> +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py > >> @@ -89,6 +89,7 @@ class hcc: > >> "cpio.xz" : ["cpio.xz"], > >> "vmdk" : ["vmdk"], > >> "cpio.lzma" : ["cpio.lzma"], > >> + "elf" : ["elf"], > >> } > >> > >> class HobViewTable (gtk.VBox): > > Hi Richard, > > Thanks. > > > Why do we have a hardcoded list here and why do new image types cause > > builds to fail? > After build the image, Hob trys to get list of created images. It needs > a map from image type to real image file's extend name, such as "live" > --> "hddimg" and "iso". > then search the image output dir to get the list. > > > > We need to rewrite this code so this does not happen and the user at > > least gets a sensible error message. Hardcoded lists are bad... > > For the current, only image type 'live' need this map. So I can remove > the list and check the image type is whether 'live' or not. > But for the future, if a new image type added and need this kind of map, > new check for the single type is needed. I think for this scenario the > list is better. Well, I *hate* the concept that if you add a new image type, the UI has to be changed. Ideally, we need to add something to the metadata that explains this mapping to the UI. I want to see the hardcoded list removed from the UI, one way or another. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] hob2: add elf to hcc supported image types 2012-07-18 13:15 ` Richard Purdie @ 2012-07-19 3:16 ` Kang Kai 0 siblings, 0 replies; 6+ messages in thread From: Kang Kai @ 2012-07-19 3:16 UTC (permalink / raw) To: Richard Purdie; +Cc: bitbake-devel, Zhenfeng.Zhao [-- Attachment #1: Type: text/plain, Size: 2471 bytes --] On 2012年07月18日 21:15, Richard Purdie wrote: > On Wed, 2012-07-18 at 11:13 +0800, Kang Kai wrote: >> On 2012年07月17日 17:52, Richard Purdie wrote: >>> On Tue, 2012-07-17 at 14:58 +0800, Kang Kai wrote: >>>> [Yocto #2709] >>>> >>>> OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image >>>> type. This will cause hob build image failed. >>>> Add elf to hcc supoorted image types to fix this issue. >>>> >>>> Signed-off-by: Kang Kai<kai.kang@windriver.com> >>>> --- >>>> bitbake/lib/bb/ui/crumbs/hobwidget.py | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/bitbake/lib/bb/ui/crumbs/hobwidget.py b/bitbake/lib/bb/ui/crumbs/hobwidget.py >>>> index dba278c..d10c56b 100644 >>>> --- a/bitbake/lib/bb/ui/crumbs/hobwidget.py >>>> +++ b/bitbake/lib/bb/ui/crumbs/hobwidget.py >>>> @@ -89,6 +89,7 @@ class hcc: >>>> "cpio.xz" : ["cpio.xz"], >>>> "vmdk" : ["vmdk"], >>>> "cpio.lzma" : ["cpio.lzma"], >>>> + "elf" : ["elf"], >>>> } >>>> >>>> class HobViewTable (gtk.VBox): >> Hi Richard, >> >> Thanks. >> >>> Why do we have a hardcoded list here and why do new image types cause >>> builds to fail? >> After build the image, Hob trys to get list of created images. It needs >> a map from image type to real image file's extend name, such as "live" >> --> "hddimg" and "iso". >> then search the image output dir to get the list. >>> We need to rewrite this code so this does not happen and the user at >>> least gets a sensible error message. Hardcoded lists are bad... >> For the current, only image type 'live' need this map. So I can remove >> the list and check the image type is whether 'live' or not. >> But for the future, if a new image type added and need this kind of map, >> new check for the single type is needed. I think for this scenario the >> list is better. Hi Richard, > Well, I *hate* the concept that if you add a new image type, the UI has > to be changed. > > Ideally, we need to add something to the metadata that explains this > mapping to the UI. I want to see the hardcoded list removed from the UI, > one way or another. I create *Bug 2795* <https://bugzilla.yoctoproject.org/show_bug.cgi?id=2795> to follow this issue, and 2709 is closed suggested by Jessica. Regards, Kai <mailto:jessica.zhang@intel.com> > > Cheers, > > Richard > > [-- Attachment #2: Type: text/html, Size: 3701 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-19 3:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-17 6:58 [PATCH 0/1] hob2: add elf to image types Kang Kai 2012-07-17 6:58 ` [PATCH 1/1] hob2: add elf to hcc supported " Kang Kai 2012-07-17 9:52 ` Richard Purdie 2012-07-18 3:13 ` Kang Kai 2012-07-18 13:15 ` Richard Purdie 2012-07-19 3:16 ` Kang Kai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox