* [PATCH 0/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP @ 2012-08-10 2:02 Robert Yang 2012-08-10 2:02 ` [PATCH 1/1] " Robert Yang 0 siblings, 1 reply; 6+ messages in thread From: Robert Yang @ 2012-08-10 2:02 UTC (permalink / raw) To: bitbake-devel; +Cc: Zhenfeng.Zhao The following changes since commit 5290e82ecef08b5e573d7442627276d7b42c6b93: foomatic: fix perl path for target (2012-08-08 10:05:52 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib robert/stampsdir http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/stampsdir Robert Yang (1): bitbake.conf: add BB_STAMPS_DIR for constructing STAMP meta/conf/bitbake.conf | 3 ++- scripts/oe-buildenv-internal | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 1.7.11.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP 2012-08-10 2:02 [PATCH 0/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP Robert Yang @ 2012-08-10 2:02 ` Robert Yang 2012-08-15 13:42 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Robert Yang @ 2012-08-10 2:02 UTC (permalink / raw) To: bitbake-devel; +Cc: Zhenfeng.Zhao Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP before: STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF} We can only change the TMPDIR if we want to change the STAMP's location, but the cache would be regenerated if TMPDIR changed, so add BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE, this is very usefull for the "bitbake -S", since then it can be run by: BB_STAMPS_DIR=<path> bitbake -S <recipe> which will avoid putting the stamps to ${TMPDIR}/stamps. BTW, break the too long BB_ENV_EXTRAWHITE into several lines. [YOCTO #1659] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/conf/bitbake.conf | 3 ++- scripts/oe-buildenv-internal | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index d5a43e9..8440e65 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -332,7 +332,8 @@ GITDIR = "${CO_DIR}/git2" BZRDIR = "${CO_DIR}/bzr" HGDIR = "${CO_DIR}/hg" -STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF}" +BB_STAMPS_DIR ?= "${TMPDIR}/stamps" +STAMP = "${BB_STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PF}" WORKDIR = "${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}" T = "${WORKDIR}/temp" D = "${WORKDIR}/image" diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal index 32c0ba0..2674ff7 100755 --- a/scripts/oe-buildenv-internal +++ b/scripts/oe-buildenv-internal @@ -75,4 +75,7 @@ unset BITBAKEDIR # Used by the runqemu script export BUILDDIR export PATH -export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC http_proxy ftp_proxy https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY SDKMACHINE BB_NUMBER_THREADS PARALLEL_MAKE GIT_PROXY_COMMAND GIT_PROXY_IGNORE SOCKS5_PASSWD SOCKS5_USER SCREENDIR" +export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC http_proxy ftp_proxy + https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY + SDKMACHINE BB_NUMBER_THREADS PARALLEL_MAKE GIT_PROXY_COMMAND GIT_PROXY_IGNORE + SOCKS5_PASSWD SOCKS5_USER SCREENDIR BB_STAMPS_DIR" -- 1.7.11.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP 2012-08-10 2:02 ` [PATCH 1/1] " Robert Yang @ 2012-08-15 13:42 ` Richard Purdie 2012-08-15 13:49 ` Robert Yang 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2012-08-15 13:42 UTC (permalink / raw) To: Robert Yang; +Cc: bitbake-devel, Zhenfeng.Zhao On Fri, 2012-08-10 at 10:02 +0800, Robert Yang wrote: > Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP > before: > > STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF} > > We can only change the TMPDIR if we want to change the STAMP's location, > but the cache would be regenerated if TMPDIR changed, so add > BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE, > this is very usefull for the "bitbake -S", since then it can be run by: > > BB_STAMPS_DIR=<path> bitbake -S <recipe> > > which will avoid putting the stamps to ${TMPDIR}/stamps. > > BTW, break the too long BB_ENV_EXTRAWHITE into several lines. > > [YOCTO #1659] > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > meta/conf/bitbake.conf | 3 ++- > scripts/oe-buildenv-internal | 5 ++++- > 2 files changed, 6 insertions(+), 2 deletions(-) BB_ is a prefix for variables bitbake specifically uses for configuration. It doesn't fit in this context since its metadata defined and doesn't actually influence or is used by bitbake itself. We therefore need to use a different name for this. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP 2012-08-15 13:42 ` Richard Purdie @ 2012-08-15 13:49 ` Robert Yang 2012-08-15 14:00 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Robert Yang @ 2012-08-15 13:49 UTC (permalink / raw) To: Richard Purdie; +Cc: Chris Larson, bitbake-devel, Zhenfeng.Zhao On 08/15/2012 09:42 PM, Richard Purdie wrote: > On Fri, 2012-08-10 at 10:02 +0800, Robert Yang wrote: >> Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP >> before: >> >> STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF} >> >> We can only change the TMPDIR if we want to change the STAMP's location, >> but the cache would be regenerated if TMPDIR changed, so add >> BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE, >> this is very usefull for the "bitbake -S", since then it can be run by: >> >> BB_STAMPS_DIR=<path> bitbake -S <recipe> >> >> which will avoid putting the stamps to ${TMPDIR}/stamps. >> >> BTW, break the too long BB_ENV_EXTRAWHITE into several lines. >> >> [YOCTO #1659] >> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >> --- >> meta/conf/bitbake.conf | 3 ++- >> scripts/oe-buildenv-internal | 5 ++++- >> 2 files changed, 6 insertions(+), 2 deletions(-) > > BB_ is a prefix for variables bitbake specifically uses for > configuration. It doesn't fit in this context since its metadata defined > and doesn't actually influence or is used by bitbake itself. > > We therefore need to use a different name for this. > Thanks, how about "STAMPS_DIR" ? And can we put the bitbake-whatchanged to bitbake/bin or bitbake/contrib as Chris Larson worried about ? // Robert > Cheers, > > Richard > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP 2012-08-15 13:49 ` Robert Yang @ 2012-08-15 14:00 ` Richard Purdie 2012-08-15 14:13 ` Robert Yang 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2012-08-15 14:00 UTC (permalink / raw) To: Robert Yang; +Cc: Chris, Larson, bitbake-devel, Zhenfeng.Zhao On Wed, 2012-08-15 at 21:49 +0800, Robert Yang wrote: > > On 08/15/2012 09:42 PM, Richard Purdie wrote: > > On Fri, 2012-08-10 at 10:02 +0800, Robert Yang wrote: > >> Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP > >> before: > >> > >> STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF} > >> > >> We can only change the TMPDIR if we want to change the STAMP's location, > >> but the cache would be regenerated if TMPDIR changed, so add > >> BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE, > >> this is very usefull for the "bitbake -S", since then it can be run by: > >> > >> BB_STAMPS_DIR=<path> bitbake -S <recipe> > >> > >> which will avoid putting the stamps to ${TMPDIR}/stamps. > >> > >> BTW, break the too long BB_ENV_EXTRAWHITE into several lines. > >> > >> [YOCTO #1659] > >> > >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > >> --- > >> meta/conf/bitbake.conf | 3 ++- > >> scripts/oe-buildenv-internal | 5 ++++- > >> 2 files changed, 6 insertions(+), 2 deletions(-) > > > > BB_ is a prefix for variables bitbake specifically uses for > > configuration. It doesn't fit in this context since its metadata defined > > and doesn't actually influence or is used by bitbake itself. > > > > We therefore need to use a different name for this. > > > > Thanks, how about "STAMPS_DIR" ? And can we put the bitbake-whatchanged > to bitbake/bin or bitbake/contrib as Chris Larson worried about ? He's right, it depends on the metadata and therefore shouldn't really be in bitbake. It could go into scripts/ in oe-core. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP 2012-08-15 14:00 ` Richard Purdie @ 2012-08-15 14:13 ` Robert Yang 0 siblings, 0 replies; 6+ messages in thread From: Robert Yang @ 2012-08-15 14:13 UTC (permalink / raw) To: Richard Purdie; +Cc: Chris Larson, bitbake-devel, Zhenfeng.Zhao On 08/15/2012 10:00 PM, Richard Purdie wrote: > On Wed, 2012-08-15 at 21:49 +0800, Robert Yang wrote: >> >> On 08/15/2012 09:42 PM, Richard Purdie wrote: >>> On Fri, 2012-08-10 at 10:02 +0800, Robert Yang wrote: >>>> Add BB_STAMPS_DIR for constructing STAMP, the defination of STAMP >>>> before: >>>> >>>> STAMP = "${TMPDIR}/stamps/${MULTIMACH_TARGET_SYS}/${PF} >>>> >>>> We can only change the TMPDIR if we want to change the STAMP's location, >>>> but the cache would be regenerated if TMPDIR changed, so add >>>> BB_STAMPS_DIR for constructing it, and add it to the BB_ENV_EXTRAWHITE, >>>> this is very usefull for the "bitbake -S", since then it can be run by: >>>> >>>> BB_STAMPS_DIR=<path> bitbake -S <recipe> >>>> >>>> which will avoid putting the stamps to ${TMPDIR}/stamps. >>>> >>>> BTW, break the too long BB_ENV_EXTRAWHITE into several lines. >>>> >>>> [YOCTO #1659] >>>> >>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >>>> --- >>>> meta/conf/bitbake.conf | 3 ++- >>>> scripts/oe-buildenv-internal | 5 ++++- >>>> 2 files changed, 6 insertions(+), 2 deletions(-) >>> >>> BB_ is a prefix for variables bitbake specifically uses for >>> configuration. It doesn't fit in this context since its metadata defined >>> and doesn't actually influence or is used by bitbake itself. >>> >>> We therefore need to use a different name for this. >>> >> >> Thanks, how about "STAMPS_DIR" ? And can we put the bitbake-whatchanged >> to bitbake/bin or bitbake/contrib as Chris Larson worried about ? > > He's right, it depends on the metadata and therefore shouldn't really be > in bitbake. It could go into scripts/ in oe-core. > Thanks, I will send a V3 to oe-core list. // Robert > Cheers, > > Richard > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-15 14:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-08-10 2:02 [PATCH 0/1] bitbake.conf: add BB_STAMPS_DIR for constructing STAMP Robert Yang 2012-08-10 2:02 ` [PATCH 1/1] " Robert Yang 2012-08-15 13:42 ` Richard Purdie 2012-08-15 13:49 ` Robert Yang 2012-08-15 14:00 ` Richard Purdie 2012-08-15 14:13 ` Robert Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox