Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [PATCH 0/1] Clear Knotty footer before outputting to stderr
@ 2014-04-08 14:09 Peter Kjellerstedt
  2014-04-08 14:09 ` [PATCH 1/1] bitbake: knotty: Clear " Peter Kjellerstedt
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Kjellerstedt @ 2014-04-08 14:09 UTC (permalink / raw)
  To: bitbake-devel

This fixes a problem with Knotty when errors are output to stderr
while the footer of currently active tasks is displayed.

//Peter

The following changes since commit 68a55c8ff779d8df90626e68d5d4e48660dd8027:

  ref-manual: Edits to fix up how GID and UIDs are handled. (2014-04-08 14:20:16 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/knotty_stderr
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/knotty_stderr

Peter Kjellerstedt (1):
  bitbake: knotty: Clear footer before outputting to stderr

 bitbake/lib/bb/ui/knotty.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
1.9.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] bitbake: knotty: Clear footer before outputting to stderr
  2014-04-08 14:09 [PATCH 0/1] Clear Knotty footer before outputting to stderr Peter Kjellerstedt
@ 2014-04-08 14:09 ` Peter Kjellerstedt
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Kjellerstedt @ 2014-04-08 14:09 UTC (permalink / raw)
  To: bitbake-devel

With the recent change to split the log output to stdout and stderr,
error messages that appeared while the footer was printed got all
messed up. This was because the messages to stderr was output _after_
the footer, then clearFooter() tried to remove the footer but removed
the error message and parts of the footer.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 bitbake/lib/bb/ui/knotty.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 80a4b32..41f1ba8 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -133,7 +133,7 @@ class TerminalFilter(object):
                 cr = (25, 80)
         return cr[1]
 
-    def __init__(self, main, helper, console, format):
+    def __init__(self, main, helper, console, errconsole, format):
         self.main = main
         self.helper = helper
         self.cuu = None
@@ -174,6 +174,7 @@ class TerminalFilter(object):
         except:
             self.cuu = None
         console.addFilter(InteractConsoleLogFilter(self, format))
+        errconsole.addFilter(InteractConsoleLogFilter(self, format))
 
     def clearFooter(self):
         if self.footer_present:
@@ -309,7 +310,7 @@ def main(server, eventHandler, params, tf = TerminalFilter):
     warnings = 0
     taskfailures = []
 
-    termfilter = tf(main, helper, console, format)
+    termfilter = tf(main, helper, console, errconsole, format)
     atexit.register(termfilter.finish)
 
     while True:
-- 
1.9.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-08 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 14:09 [PATCH 0/1] Clear Knotty footer before outputting to stderr Peter Kjellerstedt
2014-04-08 14:09 ` [PATCH 1/1] bitbake: knotty: Clear " Peter Kjellerstedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox