Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [PATCH 0/1] bitbake-diffsigs: fix traceback with no arguments
@ 2017-04-10 22:35 Paul Eggleton
  2017-04-10 22:35 ` [PATCH 1/1] " Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2017-04-10 22:35 UTC (permalink / raw)
  To: bitbake-devel

The following changes since commit 04a023c8fdea1e1812fcdcaf00345aab59f9abe1:

  bitbake-diffsigs: colourise output (2017-04-07 00:51:12 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib paule/bb-sigstuff-fix
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/bb-sigstuff-fix

Paul Eggleton (1):
  bitbake-diffsigs: fix traceback with no arguments

 bin/bitbake-diffsigs | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.9.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] bitbake-diffsigs: fix traceback with no arguments
  2017-04-10 22:35 [PATCH 0/1] bitbake-diffsigs: fix traceback with no arguments Paul Eggleton
@ 2017-04-10 22:35 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2017-04-10 22:35 UTC (permalink / raw)
  To: bitbake-devel

In the move over to argparse we've made the two signature file arguments
optional and thus if -t is not in use we need to explicitly check if at
least one signature file has been specified - and if not, show an error
and the command-line help.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 bin/bitbake-diffsigs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bin/bitbake-diffsigs b/bin/bitbake-diffsigs
index 884be1e..eb2f859 100755
--- a/bin/bitbake-diffsigs
+++ b/bin/bitbake-diffsigs
@@ -147,6 +147,10 @@ else:
             output = bb.siggen.compare_sigfiles(options.sigdatafile1, options.sigdatafile2, color=color)
         elif options.sigdatafile1:
             output = bb.siggen.dump_sigfile(options.sigdatafile1)
+        else:
+            logger.error('Must specify signature file(s) or -t/--task')
+            parser.print_help()
+            sys.exit(1)
     except IOError as e:
         logger.error(str(e))
         sys.exit(1)
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-10 22:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-10 22:35 [PATCH 0/1] bitbake-diffsigs: fix traceback with no arguments Paul Eggleton
2017-04-10 22:35 ` [PATCH 1/1] " Paul Eggleton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox