[PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

Hi RP,

I'd like to change the fatal message to be an event, the benefits are:
- Things like report-error.bbclass can catch the error
- It's easier to get bbappends list from an event message than from console log.

What's your opinion, please ?

// Robert

The following changes since commit 41d89552620bfbc94031d314e6b3d0324f7a330e:

  bitbake: fetch2: Avoid warning about incorrect character escaping in regex (2018-11-27 22:15:34 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib rbt/append
  http://git.pokylinux.org/cgit.cgi//log/?h=rbt/append

Robert Yang (1):
  cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.7.4

[PATCH 1/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

- d.getVar('BB_DANGLINGAPPENDS_WARNONLY', False) -> d.getVar('BB_DANGLINGAPPENDS_WARNONLY')
  There is no reason to use 'False'.

- Use bb.utils.to_boolean for warn_only.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 16681ba..28a16c5 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -928,9 +928,8 @@ class BBCooker:
 
         if appends_without_recipes:
             msg = 'No recipes available for:\n  %s' % '\n  '.join(appends_without_recipes)
-            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY", \
-                 False) or "no"
-            if warn_only.lower() in ("1", "yes", "true"):
+            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY")
+            if bb.utils.to_boolean(warn_only):
                 bb.warn(msg)
             else:
                 bb.fatal(msg)
-- 
2.7.4