[PATCH 0/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[PATCH 0/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Robert Yang]

The following changes since commit 1979d9162a335b7d4718a6697ca57bfa16237f0e:

  bitbake: gitsmy.py: Fix unpack of submodules of submodules (2019-01-24 17:45:49 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib rbt/bbfile
  http://git.pokylinux.org/cgit.cgi//log/?h=rbt/bbfile

Robert Yang (1):
  bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

 bitbake/lib/bb/cookerdata.py | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.7.4

[PATCH 1/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Robert Yang]

It shouldn't work when there are duplicated BBFILE_COLLECTIONS.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/cookerdata.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bitbake/lib/bb/cookerdata.py b/bitbake/lib/bb/cookerdata.py
index 5df66e6..09412e2 100644
--- a/bitbake/lib/bb/cookerdata.py
+++ b/bitbake/lib/bb/cookerdata.py
@@ -391,7 +391,11 @@ class CookerDataBuilder(object):
                 bb.fatal("BBFILES_DYNAMIC entries must be of the form <collection name>:<filename pattern>, not:\n    %s" % "\n    ".join(invalid))
 
             layerseries = set((data.getVar("LAYERSERIES_CORENAMES") or "").split())
+            collections_tmp = collections[:]
             for c in collections:
+                collections_tmp.remove(c)
+                if c in collections_tmp:
+                    bb.fatal("Found duplicated BBFILE_COLLECTIONS '%s', check bblayers.conf or layer.conf to fix it." % c)
                 compat = set((data.getVar("LAYERSERIES_COMPAT_%s" % c) or "").split())
                 if compat and not (compat & layerseries):
                     bb.fatal("Layer %s is not compatible with the core layer which only supports these series: %s (layer is compatible with %s)"
-- 
2.7.4

Re: [PATCH 1/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Richard Purdie]

On Fri, 2019-01-25 at 15:09 +0800, Robert Yang wrote:
> It shouldn't work when there are duplicated BBFILE_COLLECTIONS.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  bitbake/lib/bb/cookerdata.py | 4 ++++
>  1 file changed, 4 insertions(+)

This caused a load of failures on yocto-check-layer:

https://autobuilder.yoctoproject.org/typhoon/#/builders/39/builds/259

We may need to fix that behaviour of that script?

Not sure if this is highlighting a bug or not...

Cheers,

Richard

Re: [PATCH 1/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Mark Hatle]

On 2/5/19 9:14 AM, Richard Purdie wrote:
> On Fri, 2019-01-25 at 15:09 +0800, Robert Yang wrote:
>> It shouldn't work when there are duplicated BBFILE_COLLECTIONS.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>  bitbake/lib/bb/cookerdata.py | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> This caused a load of failures on yocto-check-layer:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/39/builds/259
> 
> We may need to fix that behaviour of that script?
> 
> Not sure if this is highlighting a bug or not...

I think it is highlighting a bug in the yocto-check-layer.

I've seen instances in the past where something has failed (or been aborted),
and the yocto-check-layer didn't cleanup after itself.

Due to this, we had various configuration files load multiple times (since the
layer was loaded multiple times) which caused problems throughout the system.

The yocto-check-layer needs to somehow verify that it's not added the same layer
multiple times.

--Mark

> Cheers,
> 
> Richard
> 

Re: [PATCH 1/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Robert Yang]

On 2/6/19 12:43 AM, Mark Hatle wrote:
> On 2/5/19 9:14 AM, Richard Purdie wrote:
>> On Fri, 2019-01-25 at 15:09 +0800, Robert Yang wrote:
>>> It shouldn't work when there are duplicated BBFILE_COLLECTIONS.
>>>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>> ---
>>>   bitbake/lib/bb/cookerdata.py | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>
>> This caused a load of failures on yocto-check-layer:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/39/builds/259
>>
>> We may need to fix that behaviour of that script?
>>
>> Not sure if this is highlighting a bug or not...
> 
> I think it is highlighting a bug in the yocto-check-layer.
> 
> I've seen instances in the past where something has failed (or been aborted),
> and the yocto-check-layer didn't cleanup after itself.
> 
> Due to this, we had various configuration files load multiple times (since the
> layer was loaded multiple times) which caused problems throughout the system.
> 
> The yocto-check-layer needs to somehow verify that it's not added the same layer
> multiple times.

Sorry, I just came back from holiday, I will work on it if it has not been fixed.

// Robert

> 
> --Mark
> 
>> Cheers,
>>
>> Richard
>>
> 
> 

Re: [PATCH 1/1] bitbake: cookerdata: Check duplicated BBFILE_COLLECTIONS

[Robert Yang]

On 2/12/19 10:02 AM, Robert Yang wrote:
> 
> 
> On 2/6/19 12:43 AM, Mark Hatle wrote:
>> On 2/5/19 9:14 AM, Richard Purdie wrote:
>>> On Fri, 2019-01-25 at 15:09 +0800, Robert Yang wrote:
>>>> It shouldn't work when there are duplicated BBFILE_COLLECTIONS.
>>>>
>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>> ---
>>>>   bitbake/lib/bb/cookerdata.py | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>
>>> This caused a load of failures on yocto-check-layer:
>>>
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/39/builds/259
>>>
>>> We may need to fix that behaviour of that script?
>>>
>>> Not sure if this is highlighting a bug or not...
>>
>> I think it is highlighting a bug in the yocto-check-layer.
>>
>> I've seen instances in the past where something has failed (or been aborted),
>> and the yocto-check-layer didn't cleanup after itself.
>>
>> Due to this, we had various configuration files load multiple times (since the
>> layer was loaded multiple times) which caused problems throughout the system.
>>
>> The yocto-check-layer needs to somehow verify that it's not added the same layer
>> multiple times.
> 
> Sorry, I just came back from holiday, I will work on it if it has not been fixed.

I've sent 2 patches in oe-core to fix yocto-check-layer:

http://lists.openembedded.org/pipermail/openembedded-core/2019-February/278919.html

// Robert

> 
> // Robert
> 
>>
>> --Mark
>>
>>> Cheers,
>>>
>>> Richard
>>>
>>
>>