Openembedded Bitbake Development
 help / color / mirror / Atom feed
* [1.52][PATCH 0/1] Pull request
@ 2021-12-14  1:25 Anuj Mittal
  2021-12-14  1:25 ` [1.52][PATCH 1/1] lib/pyinotify.py: Remove deprecated module asyncore Anuj Mittal
  0 siblings, 1 reply; 2+ messages in thread
From: Anuj Mittal @ 2021-12-14  1:25 UTC (permalink / raw)
  To: bitbake-devel

Please review and merge this change for 1.52. Tested and no problems
seen.

Thanks,

Anuj

The following changes since commit 5c46ce77aa55cb46abe224b6a31dad87b9249bcf:

  data_smart.py: Skip old override syntax checking for anonymous functions (2021-12-12 22:24:22 +0000)

are available in the Git repository at:

  git://push.openembedded.org/bitbake-contrib stable/1.52-next

Robert Yang (1):
  lib/pyinotify.py: Remove deprecated module asyncore

 lib/pyinotify.py | 30 ------------------------------
 1 file changed, 30 deletions(-)

-- 
2.33.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [1.52][PATCH 1/1] lib/pyinotify.py: Remove deprecated module asyncore
  2021-12-14  1:25 [1.52][PATCH 0/1] Pull request Anuj Mittal
@ 2021-12-14  1:25 ` Anuj Mittal
  0 siblings, 0 replies; 2+ messages in thread
From: Anuj Mittal @ 2021-12-14  1:25 UTC (permalink / raw)
  To: bitbake-devel

From: Robert Yang <liezhi.yang@windriver.com>

When build with nativesdk-python3 (3.10) from buildtools:
/path/to/bitbake/lib/pyinotify.py:55: DeprecationWarning: The asyncore module is deprecated. The recommended replacement is asyncio

The pyinotify.py's upstream didn't have any update in recent 7 years:
https://github.com/seb-m/pyinotify

And bitbake doesn't use the asyncore module, so remove the related code.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
---
 lib/pyinotify.py | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/lib/pyinotify.py b/lib/pyinotify.py
index 6ae40a2d..8c94b3e3 100644
--- a/lib/pyinotify.py
+++ b/lib/pyinotify.py
@@ -52,7 +52,6 @@ from collections import deque
 from datetime import datetime, timedelta
 import time
 import re
-import asyncore
 import glob
 import locale
 import subprocess
@@ -1475,35 +1474,6 @@ class ThreadedNotifier(threading.Thread, Notifier):
         self.loop()
 
 
-class AsyncNotifier(asyncore.file_dispatcher, Notifier):
-    """
-    This notifier inherits from asyncore.file_dispatcher in order to be able to
-    use pyinotify along with the asyncore framework.
-
-    """
-    def __init__(self, watch_manager, default_proc_fun=None, read_freq=0,
-                 threshold=0, timeout=None, channel_map=None):
-        """
-        Initializes the async notifier. The only additional parameter is
-        'channel_map' which is the optional asyncore private map. See
-        Notifier class for the meaning of the others parameters.
-
-        """
-        Notifier.__init__(self, watch_manager, default_proc_fun, read_freq,
-                          threshold, timeout)
-        asyncore.file_dispatcher.__init__(self, self._fd, channel_map)
-
-    def handle_read(self):
-        """
-        When asyncore tells us we can read from the fd, we proceed processing
-        events. This method can be overridden for handling a notification
-        differently.
-
-        """
-        self.read_events()
-        self.process_events()
-
-
 class TornadoAsyncNotifier(Notifier):
     """
     Tornado ioloop adapter.
-- 
2.33.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-14  1:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14  1:25 [1.52][PATCH 0/1] Pull request Anuj Mittal
2021-12-14  1:25 ` [1.52][PATCH 1/1] lib/pyinotify.py: Remove deprecated module asyncore Anuj Mittal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox