public inbox for bitbake-devel@lists.openembedded.org
 help / color / mirror / Atom feed
* [bitbake][scarthgap][2.8][PATCH 0/2] Patch review
@ 2024-07-18 13:48 Steve Sakoman
  0 siblings, 0 replies; 6+ messages in thread
From: Steve Sakoman @ 2024-07-18 13:48 UTC (permalink / raw)
  To: bitbake-devel

Please review this set of changes for 2.8/scarthgap and have comments back by
end of day Monday, July 21

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/7150

The following changes since commit 8714a02e13477a9d97858b3642e05f28247454b5:

  fetch2/wget: Fix failure path for files that are empty or don't exist (2024-06-14 08:48:23 -0700)

are available in the Git repository at:

  https://git.openembedded.org/bitbake-contrib stable/2.8-nut
  https://git.openembedded.org/bitbake-contrib/log/?h=stable/2.8-nut

Richard Purdie (2):
  codeparser/data: Ensure module function contents changing is accounted
    for
  codeparser: Skip non-local functions for module dependencies

 lib/bb/codeparser.py | 33 ++++++++++++++++++++++-----------
 lib/bb/data.py       |  2 +-
 2 files changed, 23 insertions(+), 12 deletions(-)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bitbake][scarthgap][2.8][PATCH 0/2] Patch review
@ 2025-09-10 15:59 Steve Sakoman
  0 siblings, 0 replies; 6+ messages in thread
From: Steve Sakoman @ 2025-09-10 15:59 UTC (permalink / raw)
  To: bitbake-devel

Please review this set of changes for 2.18/scarthgap and have comments back
by end of day Friday, September 12

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/2347

The following changes since commit 982645110a19ebb94d519926a4e14c8a2a205cfd:

  utils: Optimise signal/sigmask performance (2025-07-31 09:21:27 -0700)

are available in the Git repository at:

  https://git.openembedded.org/bitbake-contrib stable/2.8-nut
  https://git.openembedded.org/bitbake-contrib/log/?h=stable/2.8-nut

Bin Lan (1):
  bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace()

Joshua Watt (1):
  Use a "fork" multiprocessing context

 lib/bb/__init__.py                 | 28 ++++++++++++++++++++++++++++
 lib/bb/asyncrpc/serv.py            |  2 +-
 lib/bb/cooker.py                   |  2 +-
 lib/bb/fetch2/__init__.py          |  2 +-
 lib/bb/server/process.py           |  2 +-
 lib/bb/tests/support/httpserver.py |  4 ++--
 lib/bb/utils.py                    |  4 +---
 lib/hashserv/tests.py              |  2 +-
 8 files changed, 36 insertions(+), 10 deletions(-)

-- 
2.43.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bitbake][scarthgap][2.8][PATCH 0/2] Patch review
@ 2025-11-05 14:46 Steve Sakoman
  2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 1/2] bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace() Steve Sakoman
  2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 2/2] fetch2/wget: Keep query parameters in URL during checkstatus Steve Sakoman
  0 siblings, 2 replies; 6+ messages in thread
From: Steve Sakoman @ 2025-11-05 14:46 UTC (permalink / raw)
  To: bitbake-devel

Please review this set of changes for 2.8/scarthgap and have comments back by
end of day Thursday, November 6

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/2676

The following changes since commit 1c9ec1ffde75809de34c10d3ec2b40d84d258cb4:

  bitbake: Bump version to 2.8.1 (2025-09-17 23:22:33 +0100)

are available in the Git repository at:

  https://git.openembedded.org/bitbake-contrib stable/2.8-nut
  https://git.openembedded.org/bitbake-contrib/log/?h=stable/2.8-nut

Bin Lan (1):
  bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace()

Philippe-Alexandre Mathieu (1):
  fetch2/wget: Keep query parameters in URL during checkstatus

 lib/bb/fetch2/__init__.py | 2 +-
 lib/bb/fetch2/wget.py     | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.43.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bitbake][scarthgap][2.8][PATCH 1/2] bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace()
  2025-11-05 14:46 [bitbake][scarthgap][2.8][PATCH 0/2] Patch review Steve Sakoman
@ 2025-11-05 14:46 ` Steve Sakoman
  2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 2/2] fetch2/wget: Keep query parameters in URL during checkstatus Steve Sakoman
  1 sibling, 0 replies; 6+ messages in thread
From: Steve Sakoman @ 2025-11-05 14:46 UTC (permalink / raw)
  To: bitbake-devel

From: Bin Lan <bin.lan.cn@windriver.com>

There is the following warning when executing to bitbake linux-yocto:
  bitbake/lib/bb/fetch2/__init__.py:464: DeprecationWarning: 'count' is passed as positional argument

This is because the 4th parameter of re.sub(pattern, repl, string, count=0, flags=0)
is a keyword parameter. We use keyword arguments for parameters that are not positional.

Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Chris Laplante <chris.laplante@agilent.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 lib/bb/fetch2/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index 1a6ff25d4..7b75d5d83 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -460,7 +460,7 @@ def uri_replace(ud, uri_find, uri_replace, replacements, d, mirrortarball=None):
                 for k in replacements:
                     uri_replace_decoded[loc] = uri_replace_decoded[loc].replace(k, replacements[k])
                 #bb.note("%s %s %s" % (regexp, uri_replace_decoded[loc], uri_decoded[loc]))
-                result_decoded[loc] = re.sub(regexp, uri_replace_decoded[loc], uri_decoded[loc], 1)
+                result_decoded[loc] = re.sub(regexp, uri_replace_decoded[loc], uri_decoded[loc], count=1)
             if loc == 2:
                 # Handle path manipulations
                 basename = None
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bitbake][scarthgap][2.8][PATCH 2/2] fetch2/wget: Keep query parameters in URL during checkstatus
  2025-11-05 14:46 [bitbake][scarthgap][2.8][PATCH 0/2] Patch review Steve Sakoman
  2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 1/2] bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace() Steve Sakoman
@ 2025-11-05 14:46 ` Steve Sakoman
  1 sibling, 0 replies; 6+ messages in thread
From: Steve Sakoman @ 2025-11-05 14:46 UTC (permalink / raw)
  To: bitbake-devel

From: Philippe-Alexandre Mathieu <pamathieu@poum.ca>

When recreating the uri in wget's checkstatus method, we only use the
scheme, host and path. This completely strips the query parameters from
the final URI and potentially breaks the checking functionality for
URLs that require query parameters (such as the AZ fetcher with SAS
token).

This bug was resolved on master in
`096301250455e2a83bdd818a56317c62436c9981`.
This patch is adapted to the scarthgap branch.

CC: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Philippe-Alexandre Mathieu <pamathieu@poum.ca>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 lib/bb/fetch2/wget.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py
index 5bb3b2f36..2345ba6b4 100644
--- a/lib/bb/fetch2/wget.py
+++ b/lib/bb/fetch2/wget.py
@@ -344,8 +344,11 @@ class Wget(FetchMethod):
             opener = urllib.request.build_opener(*handlers)
 
             try:
-                uri_base = ud.url.split(";")[0]
-                uri = "{}://{}{}".format(urllib.parse.urlparse(uri_base).scheme, ud.host, ud.path)
+                parts = urllib.parse.urlparse(ud.url.split(";")[0])
+                if parts.query:
+                    uri = "{}://{}{}?{}".format(parts.scheme, parts.netloc, parts.path, parts.query)
+                else:
+                    uri = "{}://{}{}".format(parts.scheme, parts.netloc, parts.path)
                 r = urllib.request.Request(uri)
                 r.get_method = lambda: "HEAD"
                 # Some servers (FusionForge, as used on Alioth) require that the
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bitbake][scarthgap][2.8][PATCH 0/2] Patch review
@ 2026-02-09  9:33 Yoann Congal
  0 siblings, 0 replies; 6+ messages in thread
From: Yoann Congal @ 2026-02-09  9:33 UTC (permalink / raw)
  To: bitbake-devel

Please review this set of changes for scarthgap and have comments back by
end of day Wednesday, February 11.

Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/3183

The following changes since commit 8dcf084522b9c66a6639b5f117f554fde9b6b45a:

  fetch2/wget: Keep query parameters in URL during checkstatus (2025-11-12 15:53:31 +0000)

are available in the Git repository at:

  https://git.openembedded.org/bitbake-contrib stable/2.8-nut
  https://git.openembedded.org/bitbake-contrib/log/?h=stable/2.8-nut

for you to fetch changes up to 1b923cdd50449aaa41152b72eac8669f27ec7ec2:

  knotty: Make sure getTerminalColumns() returns two integers (2026-02-09 01:22:13 +0100)

----------------------------------------------------------------

Enrico Scholz (1):
  knotty: fix TIOCGWINSZ call for Python 3.14 and later

Zoltan Boszormenyi (1):
  knotty: Make sure getTerminalColumns() returns two integers

 lib/bb/ui/knotty.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-02-09  9:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-05 14:46 [bitbake][scarthgap][2.8][PATCH 0/2] Patch review Steve Sakoman
2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 1/2] bb/fetch2/__init__.py: remove a DeprecationWarning in uri_replace() Steve Sakoman
2025-11-05 14:46 ` [bitbake][scarthgap][2.8][PATCH 2/2] fetch2/wget: Keep query parameters in URL during checkstatus Steve Sakoman
  -- strict thread matches above, loose matches on Subject: below --
2026-02-09  9:33 [bitbake][scarthgap][2.8][PATCH 0/2] Patch review Yoann Congal
2025-09-10 15:59 Steve Sakoman
2024-07-18 13:48 Steve Sakoman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox