From: Quentin Monnet <quentin@isovalent.com>
To: Daan De Meyer <daan.j.demeyer@gmail.com>, bpf@vger.kernel.org
Cc: martin.lau@linux.dev, kernel-team@meta.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v7 6/9] bpftool: Add support for cgroup unix socket address hooks
Date: Tue, 3 Oct 2023 10:47:47 +0100 [thread overview]
Message-ID: <0c000ec4-6522-47b3-accb-e47c985a35ce@isovalent.com> (raw)
In-Reply-To: <20231003093025.475450-7-daan.j.demeyer@gmail.com>
Thanks! Please don't forget to update the version in the titles of the
patches in addition to the cover letter.
On 03/10/2023 10:30, Daan De Meyer wrote:
> Add the necessary plumbing to hook up the new cgroup unix sockaddr
> hooks into bpftool.
>
> Signed-off-by: Daan De Meyer <daan.j.demeyer@gmail.com>
> Acked-by: Quentin Monnet <quentin@isovalent.com>
> ---
> .../bpf/bpftool/Documentation/bpftool-cgroup.rst | 16 +++++++++++++---
> tools/bpf/bpftool/Documentation/bpftool-prog.rst | 8 +++++---
> tools/bpf/bpftool/bash-completion/bpftool | 14 +++++++-------
> tools/bpf/bpftool/cgroup.c | 16 +++++++++-------
> tools/bpf/bpftool/prog.c | 7 ++++---
> 5 files changed, 38 insertions(+), 23 deletions(-)
> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> index 8443a149dd17..7ec4f5671e7a 100644
> --- a/tools/bpf/bpftool/prog.c
> +++ b/tools/bpf/bpftool/prog.c
> @@ -2475,9 +2475,10 @@ static int do_help(int argc, char **argv)
> " sk_reuseport | flow_dissector | cgroup/sysctl |\n"
> " cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n"
> " cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n"
> - " cgroup/getpeername4 | cgroup/getpeername6 |\n"
> - " cgroup/getsockname4 | cgroup/getsockname6 | cgroup/sendmsg4 |\n"
> - " cgroup/sendmsg6 | cgroup/recvmsg4 | cgroup/recvmsg6 |\n"
> + " cgroup/connect_unix | cgroup/getpeername4 | cgroup/getpeername6 |\n"
> + " cgroup/getpeername_unix | cgroup/getsockname4 | cgroup/getsockname6 |\n"
> + " cgroup/getsockname_unix | cgroup/sendmsg4 | cgroup/sendmsg6 |\n"
> + " cgroup/sendmsg°unix | cgroup/recvmsg4 | cgroup/recvmsg6 | cgroup/recvmsg_unix |\n"
Typo here on "cgroup/sendmsg°unix", please fix it. The rest of the patch
still looks good to me.
Good call from Andrii on the renames, I like it better with "_unix" as
well. :)
next prev parent reply other threads:[~2023-10-03 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 9:30 [PATCH bpf-next v8 0/9] Add cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 1/9] selftests/bpf: Add missing section name tests for getpeername/getsockname Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 2/9] bpf: Propagate modified uaddrlen from cgroup sockaddr programs Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 3/9] bpf: Add bpf_sock_addr_set_unix_addr() to allow writing unix sockaddr from bpf Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 4/9] bpf: Implement cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 5/9] libbpf: Add support for cgroup unix socket address hooks Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 6/9] bpftool: " Daan De Meyer
2023-10-03 9:47 ` Quentin Monnet [this message]
2023-10-03 9:30 ` [PATCH bpf-next v7 7/9] documentation/bpf: Document " Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 8/9] selftests/bpf: Make sure mount directory exists Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 9/9] selftests/bpf: Add tests for cgroup unix socket address hooks Daan De Meyer
2023-10-05 17:12 ` Martin KaFai Lau
-- strict thread matches above, loose matches on Subject: below --
2023-10-02 12:27 [PATCH bpf-next v7 0/9] Add cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-02 12:27 ` [PATCH bpf-next v7 6/9] bpftool: Add support for cgroup unix socket address hooks Daan De Meyer
2023-10-02 13:10 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c000ec4-6522-47b3-accb-e47c985a35ce@isovalent.com \
--to=quentin@isovalent.com \
--cc=bpf@vger.kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox