From: Martin KaFai Lau <martin.lau@linux.dev>
To: Daan De Meyer <daan.j.demeyer@gmail.com>
Cc: kernel-team@meta.com, netdev@vger.kernel.org, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v7 9/9] selftests/bpf: Add tests for cgroup unix socket address hooks
Date: Thu, 5 Oct 2023 10:12:40 -0700 [thread overview]
Message-ID: <49517916-e848-8dfe-48c5-f2240c6e740d@linux.dev> (raw)
In-Reply-To: <20231003093025.475450-10-daan.j.demeyer@gmail.com>
On 10/3/23 2:30 AM, Daan De Meyer wrote:
> These selftests are written in prog_tests style instead of adding
> them to the existing test_sock_addr tests. Migrating the existing
> sock addr tests to prog_tests style is left for future work. This
> commit adds support for testing bind() sockaddr hooks, even though
> there's no unix socket sockaddr hook for bind(). We leave this code
> intact for when the INET and INET6 tests are migrated in the future
> which do support intercepting bind().
>
> Signed-off-by: Daan De Meyer <daan.j.demeyer@gmail.com>
> ---
> tools/testing/selftests/bpf/bpf_kfuncs.h | 14 +
> tools/testing/selftests/bpf/network_helpers.c | 34 +
> tools/testing/selftests/bpf/network_helpers.h | 1 +
> .../selftests/bpf/prog_tests/section_names.c | 25 +
> .../selftests/bpf/prog_tests/sock_addr.c | 612 ++++++++++++++++++
The progs/*_unix_prog.c is missing again, probably due to the rename. Please
monitor the CI test result:
https://patchwork.kernel.org/project/netdevbpf/patch/20231003093025.475450-2-daan.j.demeyer@gmail.com/
https://github.com/kernel-patches/bpf/actions/runs/6391271804/job/17346211558
A 'git status' to check for untracked file before 'git format-patch' can help also.
next prev parent reply other threads:[~2023-10-05 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 9:30 [PATCH bpf-next v8 0/9] Add cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 1/9] selftests/bpf: Add missing section name tests for getpeername/getsockname Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 2/9] bpf: Propagate modified uaddrlen from cgroup sockaddr programs Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 3/9] bpf: Add bpf_sock_addr_set_unix_addr() to allow writing unix sockaddr from bpf Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 4/9] bpf: Implement cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 5/9] libbpf: Add support for cgroup unix socket address hooks Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 6/9] bpftool: " Daan De Meyer
2023-10-03 9:47 ` Quentin Monnet
2023-10-03 9:30 ` [PATCH bpf-next v7 7/9] documentation/bpf: Document " Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 8/9] selftests/bpf: Make sure mount directory exists Daan De Meyer
2023-10-03 9:30 ` [PATCH bpf-next v7 9/9] selftests/bpf: Add tests for cgroup unix socket address hooks Daan De Meyer
2023-10-05 17:12 ` Martin KaFai Lau [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-02 12:27 [PATCH bpf-next v7 0/9] Add cgroup sockaddr hooks for unix sockets Daan De Meyer
2023-10-02 12:27 ` [PATCH bpf-next v7 9/9] selftests/bpf: Add tests for cgroup unix socket address hooks Daan De Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49517916-e848-8dfe-48c5-f2240c6e740d@linux.dev \
--to=martin.lau@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=kernel-team@meta.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox