public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: dthaler1968@googlemail.com
To: <bpf@ietf.org>, <bpf@vger.kernel.org>
Cc: <draft-ietf-bpf-isa.all@ietf.org>,
	"'Ines Robles'" <mariainesrobles@googlemail.com>
Subject: RE: Genart last call review of draft-ietf-bpf-isa-02
Date: Fri, 24 May 2024 07:15:07 -0700	[thread overview]
Message-ID: <0ce301daade4$c8a890d0$59f9b270$@gmail.com> (raw)
In-Reply-To: <171588680595.59757.9400896368334392439@ietfa.amsl.com>

> -----Original Message-----
> From: Ines Robles via Datatracker <noreply@ietf.org>
> Sent: Thursday, May 16, 2024 12:13 PM
> To: gen-art@ietf.org
> Cc: bpf@ietf.org; draft-ietf-bpf-isa.all@ietf.org; last-call@ietf.org
> Subject: Genart last call review of draft-ietf-bpf-isa-02
> 
> Reviewer: Ines Robles
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comments.
> 
> For more information, please see the FAQ at
> 
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
> 
> Document: draft-ietf-bpf-isa-02
> Reviewer: Ines Robles
> Review Date: 2024-05-16
> IETF LC End Date: 2024-05-16
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This document specifies the BPF instruction set architecture (ISA). The document
> is clear and well-written. No major issues were found, just some minor
> suggestions.
> 
> Major issues: None
> Minor issues: None
> Nits/editorial comments:
> 
> * In the introduction, maybe?: "eBPF (which is no longer an acronym for anything),
> also commonly referred to as BPF" --> eBPF (which originally stood for "extended
> Berkeley Packet Filter" but is no longer an acronym), also commonly referred to as
> BPF...

This sounds reasonable to me but at one point the BPF Steering Committee (BSC)
discussed the text to appear on the eBPF Foundation website at
https://ebpf.foundation/ebpf-resources/
(which is where the present text there came from), and at the time they did not want
to state the expansion.

https://ebpf.io/what-is-ebpf/#what-do-ebpf-and-bpf-stand-for on the other hand does.

What do others think about Ines's suggestion?
 
> * It would be nice to add caption to the tables (from Table 3 to Table 18).

Can do.

> Thanks for this document,
> 
> Ines

Thanks for the review,
Dave


WARNING: multiple messages have this Message-ID (diff)
From: dthaler1968=40googlemail.com@dmarc.ietf.org
To: <bpf@ietf.org>, <bpf@vger.kernel.org>
Cc: draft-ietf-bpf-isa.all@ietf.org,
	'Ines Robles' <mariainesrobles@googlemail.com>
Subject: [Bpf] Re: Genart last call review of draft-ietf-bpf-isa-02
Date: Fri, 24 May 2024 07:15:07 -0700	[thread overview]
Message-ID: <0ce301daade4$c8a890d0$59f9b270$@gmail.com> (raw)
Message-ID: <20240524141507.FCVnX7hGsNvIO8GC_0E4dzycxa6zwFT4khDDZo1PsIg@z> (raw)
In-Reply-To: <171588680595.59757.9400896368334392439@ietfa.amsl.com>

> -----Original Message-----
> From: Ines Robles via Datatracker <noreply@ietf.org>
> Sent: Thursday, May 16, 2024 12:13 PM
> To: gen-art@ietf.org
> Cc: bpf@ietf.org; draft-ietf-bpf-isa.all@ietf.org; last-call@ietf.org
> Subject: Genart last call review of draft-ietf-bpf-isa-02
> 
> Reviewer: Ines Robles
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comments.
> 
> For more information, please see the FAQ at
> 
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
> 
> Document: draft-ietf-bpf-isa-02
> Reviewer: Ines Robles
> Review Date: 2024-05-16
> IETF LC End Date: 2024-05-16
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This document specifies the BPF instruction set architecture (ISA). The document
> is clear and well-written. No major issues were found, just some minor
> suggestions.
> 
> Major issues: None
> Minor issues: None
> Nits/editorial comments:
> 
> * In the introduction, maybe?: "eBPF (which is no longer an acronym for anything),
> also commonly referred to as BPF" --> eBPF (which originally stood for "extended
> Berkeley Packet Filter" but is no longer an acronym), also commonly referred to as
> BPF...

This sounds reasonable to me but at one point the BPF Steering Committee (BSC)
discussed the text to appear on the eBPF Foundation website at
https://ebpf.foundation/ebpf-resources/
(which is where the present text there came from), and at the time they did not want
to state the expansion.

https://ebpf.io/what-is-ebpf/#what-do-ebpf-and-bpf-stand-for on the other hand does.

What do others think about Ines's suggestion?
 
> * It would be nice to add caption to the tables (from Table 3 to Table 18).

Can do.

> Thanks for this document,
> 
> Ines

Thanks for the review,
Dave

-- 
Bpf mailing list -- bpf@ietf.org
To unsubscribe send an email to bpf-leave@ietf.org

       reply	other threads:[~2024-05-24 14:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171588680595.59757.9400896368334392439@ietfa.amsl.com>
2024-05-24 14:15 ` dthaler1968 [this message]
2024-05-24 14:15   ` [Bpf] Re: Genart last call review of draft-ietf-bpf-isa-02 dthaler1968=40googlemail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0ce301daade4$c8a890d0$59f9b270$@gmail.com' \
    --to=dthaler1968@googlemail.com \
    --cc=bpf@ietf.org \
    --cc=bpf@vger.kernel.org \
    --cc=draft-ietf-bpf-isa.all@ietf.org \
    --cc=mariainesrobles@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox