* [PATCH] fail_function: remove a redundant mutex unlock [not found] <20201110084245.3067324-1-luomeng12@huawei.com> @ 2020-11-18 13:49 ` Masami Hiramatsu 2020-11-19 19:10 ` patchwork-bot+netdevbpf 0 siblings, 1 reply; 2+ messages in thread From: Masami Hiramatsu @ 2020-11-18 13:49 UTC (permalink / raw) To: jbacik, ast; +Cc: bpf, mhiramat, linux-kernel, luomeng12 From: Luo Meng <luomeng12@huawei.com> Fix a mutex_unlock() issue where before copy_from_user() is not called mutex_locked. Fixes: 4b1a29a7f542 ("error-injection: Support fault injection framework") Reported-by: Hulk Robot <hulkci@huawei.com> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Luo Meng <luomeng12@huawei.com> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> --- 0 files changed diff --git a/kernel/fail_function.c b/kernel/fail_function.c index 63b349168da7..b0b1ad93fa95 100644 --- a/kernel/fail_function.c +++ b/kernel/fail_function.c @@ -253,7 +253,7 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, if (copy_from_user(buf, buffer, count)) { ret = -EFAULT; - goto out; + goto out_free; } buf[count] = '\0'; sym = strstrip(buf); @@ -307,8 +307,9 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, ret = count; } out: - kfree(buf); mutex_unlock(&fei_lock); +out_free: + kfree(buf); return ret; } ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fail_function: remove a redundant mutex unlock 2020-11-18 13:49 ` [PATCH] fail_function: remove a redundant mutex unlock Masami Hiramatsu @ 2020-11-19 19:10 ` patchwork-bot+netdevbpf 0 siblings, 0 replies; 2+ messages in thread From: patchwork-bot+netdevbpf @ 2020-11-19 19:10 UTC (permalink / raw) To: Masami Hiramatsu; +Cc: jbacik, ast, bpf, linux-kernel, luomeng12 Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 18 Nov 2020 22:49:31 +0900 you wrote: > From: Luo Meng <luomeng12@huawei.com> > > Fix a mutex_unlock() issue where before copy_from_user() is > not called mutex_locked. > > Fixes: 4b1a29a7f542 ("error-injection: Support fault injection framework") > Reported-by: Hulk Robot <hulkci@huawei.com> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > Signed-off-by: Luo Meng <luomeng12@huawei.com> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > > [...] Here is the summary with links: - fail_function: remove a redundant mutex unlock https://git.kernel.org/bpf/bpf/c/891515d945a3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-19 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201110084245.3067324-1-luomeng12@huawei.com>
2020-11-18 13:49 ` [PATCH] fail_function: remove a redundant mutex unlock Masami Hiramatsu
2020-11-19 19:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox