[PATCH bpf-next] selftests/bpf: Fix out-of-srctree build

[PATCH bpf-next] selftests/bpf: Fix out-of-srctree build

[Ilya Leoshkevich]

Building eBPF selftests out of srctree fails with:

    make: *** No rule to make target '/linux-build//ima_setup.sh', needed by 'ima_setup.sh'.  Stop.

The culprit is the rule that defines convenient shorthands like
"make test_progs", which builds $(OUTPUT)/test_progs. These shorthands
make sense only for binaries that are built though; scripts that live
in the source tree do not end up in $(OUTPUT).

Therefore drop $(TEST_PROGS) and $(TEST_PROGS_EXTENDED) from the rule.

The issue exists for a while, but it became a problem only after
commit d68ae4982cb7 ("selftests/bpf: Install all required files to run
selftests"), which added dependencies on these scripts.

Fixes: 03dcb78460c2 ("selftests/bpf: Add simple per-test targets to Makefile")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
 tools/testing/selftests/bpf/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index b2eb3201b85a..5182c0044dbb 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -151,8 +151,6 @@ endif
 # NOTE: Semicolon at the end is critical to override lib.mk's default static
 # rule for binaries.
 $(notdir $(TEST_GEN_PROGS)						\
-	 $(TEST_PROGS)							\
-	 $(TEST_PROGS_EXTENDED)						\
 	 $(TEST_GEN_PROGS_EXTENDED)					\
 	 $(TEST_CUSTOM_PROGS)): %: $(OUTPUT)/% ;
 
-- 
2.39.1

Re: [PATCH bpf-next] selftests/bpf: Fix out-of-srctree build

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Thu,  9 Feb 2023 00:12:11 +0100 you wrote:
> Building eBPF selftests out of srctree fails with:
> 
>     make: *** No rule to make target '/linux-build//ima_setup.sh', needed by 'ima_setup.sh'.  Stop.
> 
> The culprit is the rule that defines convenient shorthands like
> "make test_progs", which builds $(OUTPUT)/test_progs. These shorthands
> make sense only for binaries that are built though; scripts that live
> in the source tree do not end up in $(OUTPUT).
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Fix out-of-srctree build
    https://git.kernel.org/bpf/bpf-next/c/0b0757244754

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html