* [PATCH bpf-next v2] selftests/bpf: Drop return in bpf_testmod_exit
@ 2024-01-28 11:43 Geliang Tang
2024-01-29 15:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2024-01-28 11:43 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song
Cc: Geliang Tang, bpf, linux-kselftest, Jiri Olsa
From: Geliang Tang <tanggeliang@kylinos.cn>
bpf_testmod_exit() should not have a return value, so this patch drops this
useless 'return' in it.
Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
v2:
- rebase on top of latest bpf-next/master.
---
tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
index 8befaf17d454..6f163a0f1c94 100644
--- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
+++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
@@ -619,7 +619,7 @@ static void bpf_testmod_exit(void)
while (refcount_read(&prog_test_struct.cnt) > 1)
msleep(20);
- return sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
+ sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
}
module_init(bpf_testmod_init);
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next v2] selftests/bpf: Drop return in bpf_testmod_exit
2024-01-28 11:43 [PATCH bpf-next v2] selftests/bpf: Drop return in bpf_testmod_exit Geliang Tang
@ 2024-01-29 15:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-29 15:50 UTC (permalink / raw)
To: Geliang Tang
Cc: ast, daniel, andrii, martin.lau, song, yonghong.song, tanggeliang,
bpf, linux-kselftest, jolsa
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Sun, 28 Jan 2024 19:43:57 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> bpf_testmod_exit() should not have a return value, so this patch drops this
> useless 'return' in it.
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
>
> [...]
Here is the summary with links:
- [bpf-next,v2] selftests/bpf: Drop return in bpf_testmod_exit
https://git.kernel.org/bpf/bpf-next/c/f149d03f450b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-29 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-28 11:43 [PATCH bpf-next v2] selftests/bpf: Drop return in bpf_testmod_exit Geliang Tang
2024-01-29 15:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox