* [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h
@ 2024-05-13 11:26 Artem Savkov
2024-05-13 11:34 ` Quentin Monnet
2024-05-17 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Artem Savkov @ 2024-05-13 11:26 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf, netdev
Cc: linux-kernel, Artem Savkov, Jan Stancek
With pre-generated vmlinux.h there is no dependency on neither vmlinux
nor bootstrap bpftool. Define dependencies separately for both modes.
This avoids needless rebuilds in some corner cases.
Suggested-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
tools/bpf/bpftool/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index dfa4f1bebbb31..ba927379eb201 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -204,10 +204,11 @@ ifeq ($(feature-clang-bpf-co-re),1)
BUILD_BPF_SKELS := 1
-$(OUTPUT)vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL_BOOTSTRAP)
ifeq ($(VMLINUX_H),)
+$(OUTPUT)vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL_BOOTSTRAP)
$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) btf dump file $< format c > $@
else
+$(OUTPUT)vmlinux.h: $(VMLINUX_H)
$(Q)cp "$(VMLINUX_H)" $@
endif
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h
2024-05-13 11:26 [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h Artem Savkov
@ 2024-05-13 11:34 ` Quentin Monnet
2024-05-17 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Quentin Monnet @ 2024-05-13 11:34 UTC (permalink / raw)
To: Artem Savkov, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, bpf, netdev
Cc: linux-kernel, Jan Stancek
2024-05-13 12:27 UTC+0100 ~ Artem Savkov <asavkov@redhat.com>
> With pre-generated vmlinux.h there is no dependency on neither vmlinux
> nor bootstrap bpftool. Define dependencies separately for both modes.
> This avoids needless rebuilds in some corner cases.
>
> Suggested-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
Looks good, thank you.
Acked-by: Quentin Monnet <qmo@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h
2024-05-13 11:26 [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h Artem Savkov
2024-05-13 11:34 ` Quentin Monnet
@ 2024-05-17 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-17 3:10 UTC (permalink / raw)
To: Artem Savkov; +Cc: ast, daniel, andrii, bpf, netdev, linux-kernel, jstancek
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Mon, 13 May 2024 13:26:58 +0200 you wrote:
> With pre-generated vmlinux.h there is no dependency on neither vmlinux
> nor bootstrap bpftool. Define dependencies separately for both modes.
> This avoids needless rebuilds in some corner cases.
>
> Suggested-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
>
> [...]
Here is the summary with links:
- [bpf-next] bpftool: fix make dependencies for vmlinux.h
https://git.kernel.org/bpf/bpf-next/c/83eea61776c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-17 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-13 11:26 [PATCH bpf-next] bpftool: fix make dependencies for vmlinux.h Artem Savkov
2024-05-13 11:34 ` Quentin Monnet
2024-05-17 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox