BPF List
 help / color / mirror / Atom feed
* [PATCH bpf-next v2] bpf/btf: Use kvmemdup to simplify the code
@ 2024-08-28  6:21 Hongbo Li
  2024-08-29 19:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Hongbo Li @ 2024-08-28  6:21 UTC (permalink / raw)
  To: martin.lau, eddyz87, song, yonghong.song, john.fastabend, kpsingh,
	sdf, haoluo, jolsa
  Cc: bpf, lihongbo22

Use kvmemdup instead of kvmalloc() + memcpy() to simplify the
code.

No functional change intended.

Acked-by: Yonghong Song <yonghong.song@linux.dev>
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
v2:
  - Change the subject-prefix and add acked-by.

v1: https://lore.kernel.org/bpf/20240827112904.4017810-1-lihongbo22@huawei.com/T/
---
 kernel/bpf/btf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 9d6f9924eca7..cbbc1c2bc62e 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -6238,12 +6238,11 @@ static struct btf *btf_parse_module(const char *module_name, const void *data,
 	btf->kernel_btf = true;
 	snprintf(btf->name, sizeof(btf->name), "%s", module_name);
 
-	btf->data = kvmalloc(data_size, GFP_KERNEL | __GFP_NOWARN);
+	btf->data = kvmemdup(data, data_size, GFP_KERNEL | __GFP_NOWARN);
 	if (!btf->data) {
 		err = -ENOMEM;
 		goto errout;
 	}
-	memcpy(btf->data, data, data_size);
 	btf->data_size = data_size;
 
 	err = btf_parse_hdr(env);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH bpf-next v2] bpf/btf: Use kvmemdup to simplify the code
  2024-08-28  6:21 [PATCH bpf-next v2] bpf/btf: Use kvmemdup to simplify the code Hongbo Li
@ 2024-08-29 19:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-29 19:30 UTC (permalink / raw)
  To: Hongbo Li
  Cc: martin.lau, eddyz87, song, yonghong.song, john.fastabend, kpsingh,
	sdf, haoluo, jolsa, bpf

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 28 Aug 2024 14:21:28 +0800 you wrote:
> Use kvmemdup instead of kvmalloc() + memcpy() to simplify the
> code.
> 
> No functional change intended.
> 
> Acked-by: Yonghong Song <yonghong.song@linux.dev>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2] bpf/btf: Use kvmemdup to simplify the code
    https://git.kernel.org/bpf/bpf-next/c/c6d9dafb5955

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-29 19:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28  6:21 [PATCH bpf-next v2] bpf/btf: Use kvmemdup to simplify the code Hongbo Li
2024-08-29 19:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox