* [PATCH bpf-next] libbpf: Fixed getting wrong return address on arm64 architecture
@ 2024-09-08 9:23 Shuyi Cheng
2024-09-09 23:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Shuyi Cheng @ 2024-09-08 9:23 UTC (permalink / raw)
To: bpf; +Cc: chengshuyi, andrii, ast, daniel, song
ARM64 has a separate lr register to store the return address, so here
you only need to read the lr register to get the return address, no need
to dereference it again.
Signed-off-by: Shuyi Cheng <chengshuyi@linux.alibaba.com>
---
tools/lib/bpf/bpf_tracing.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h
index 4eab132a963e..aa3b04f5542a 100644
--- a/tools/lib/bpf/bpf_tracing.h
+++ b/tools/lib/bpf/bpf_tracing.h
@@ -522,7 +522,7 @@ struct pt_regs;
#define BPF_KPROBE_READ_RET_IP(ip, ctx) ({ (ip) = (ctx)->link; })
#define BPF_KRETPROBE_READ_RET_IP BPF_KPROBE_READ_RET_IP
-#elif defined(bpf_target_sparc)
+#elif defined(bpf_target_sparc) || defined(bpf_target_arm64)
#define BPF_KPROBE_READ_RET_IP(ip, ctx) ({ (ip) = PT_REGS_RET(ctx); })
#define BPF_KRETPROBE_READ_RET_IP BPF_KPROBE_READ_RET_IP
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH bpf-next] libbpf: Fixed getting wrong return address on arm64 architecture
2024-09-08 9:23 [PATCH bpf-next] libbpf: Fixed getting wrong return address on arm64 architecture Shuyi Cheng
@ 2024-09-09 23:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-09 23:00 UTC (permalink / raw)
To: Shuyi Cheng; +Cc: bpf, andrii, ast, daniel, song
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Sun, 8 Sep 2024 17:23:53 +0800 you wrote:
> ARM64 has a separate lr register to store the return address, so here
> you only need to read the lr register to get the return address, no need
> to dereference it again.
>
> Signed-off-by: Shuyi Cheng <chengshuyi@linux.alibaba.com>
> ---
> tools/lib/bpf/bpf_tracing.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [bpf-next] libbpf: Fixed getting wrong return address on arm64 architecture
https://git.kernel.org/bpf/bpf-next/c/12707b9159e6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-09 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-08 9:23 [PATCH bpf-next] libbpf: Fixed getting wrong return address on arm64 architecture Shuyi Cheng
2024-09-09 23:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox