BPF List
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: remove unused macro
@ 2024-10-01 20:06 Maciej Fijalkowski
  2024-10-02 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Maciej Fijalkowski @ 2024-10-01 20:06 UTC (permalink / raw)
  To: bpf, ast, daniel, andrii; +Cc: magnus.karlsson, bjorn, maciej.fijalkowski

Commit 7aebfa1b3885 ("bpf: Support narrow loads from
bpf_sock_addr.user_port") removed one and only
SOCK_ADDR_LOAD_OR_STORE_NESTED_FIELD callsite but kept the macro.

Remove it to clean up the code base. Found while getting lost in the bpf
code.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
 net/core/filter.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index 8c520634043d..a333620cb68f 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -10284,10 +10284,6 @@ static u32 xdp_convert_ctx_access(enum bpf_access_type type,
 		}							       \
 	} while (0)
 
-#define SOCK_ADDR_LOAD_OR_STORE_NESTED_FIELD(S, NS, F, NF, TF)		       \
-	SOCK_ADDR_LOAD_OR_STORE_NESTED_FIELD_SIZE_OFF(			       \
-		S, NS, F, NF, BPF_FIELD_SIZEOF(NS, NF), 0, TF)
-
 static u32 sock_addr_convert_ctx_access(enum bpf_access_type type,
 					const struct bpf_insn *si,
 					struct bpf_insn *insn_buf,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH bpf-next] bpf: remove unused macro
  2024-10-01 20:06 [PATCH bpf-next] bpf: remove unused macro Maciej Fijalkowski
@ 2024-10-02 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-02 10:00 UTC (permalink / raw)
  To: Maciej Fijalkowski; +Cc: bpf, ast, daniel, andrii, magnus.karlsson, bjorn

Hello:

This patch was applied to bpf/bpf-next.git (net)
by Daniel Borkmann <daniel@iogearbox.net>:

On Tue,  1 Oct 2024 22:06:05 +0200 you wrote:
> Commit 7aebfa1b3885 ("bpf: Support narrow loads from
> bpf_sock_addr.user_port") removed one and only
> SOCK_ADDR_LOAD_OR_STORE_NESTED_FIELD callsite but kept the macro.
> 
> Remove it to clean up the code base. Found while getting lost in the bpf
> code.
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: remove unused macro
    https://git.kernel.org/bpf/bpf-next/c/8f5b408d7661

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-02 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 20:06 [PATCH bpf-next] bpf: remove unused macro Maciej Fijalkowski
2024-10-02 10:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox