[PATCH net] net: octeontx2: Handle XDP_ABORTED and XDP invalid as XDP_DROP

[PATCH net] net: octeontx2: Handle XDP_ABORTED and XDP invalid as XDP_DROP

[Lorenzo Bianconi]

In the current implementation octeontx2 manages XDP_ABORTED and XDP
invalid as XDP_PASS forwarding the skb to the networking stack.
Align the behaviour to other XDP drivers handling XDP_ABORTED and XDP
invalid as XDP_DROP.
Please note this patch has just compile tested.

Fixes: 06059a1a9a4a5 ("octeontx2-pf: Add XDP support to netdev PF")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
index af8cabe828d05c8832085d24d183312f24d00330..0a6bb346ba45be3a5d680a49cece5042cea68583 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
@@ -1559,12 +1559,11 @@ static bool otx2_xdp_rcv_pkt_handler(struct otx2_nic *pfvf,
 		break;
 	default:
 		bpf_warn_invalid_xdp_action(pfvf->netdev, prog, act);
-		break;
+		fallthrough;
 	case XDP_ABORTED:
-		if (xsk_buff)
-			xsk_buff_free(xsk_buff);
-		trace_xdp_exception(pfvf->netdev, prog, act);
-		break;
+		if (act == XDP_ABORTED)
+			trace_xdp_exception(pfvf->netdev, prog, act);
+		fallthrough;
 	case XDP_DROP:
 		cq->pool_ptrs++;
 		if (xsk_buff) {

---
base-commit: f278b6d5bb465c7fd66f3d103812947e55b376ed
change-id: 20250401-octeontx2-xdp-abort-fix-fc6cbcd6c660

Best regards,
-- 
Lorenzo Bianconi <lorenzo@kernel.org>

Re: [PATCH net] net: octeontx2: Handle XDP_ABORTED and XDP invalid as XDP_DROP

[Paolo Abeni]

On 4/1/25 11:02 AM, Lorenzo Bianconi wrote:
> In the current implementation octeontx2 manages XDP_ABORTED and XDP
> invalid as XDP_PASS forwarding the skb to the networking stack.
> Align the behaviour to other XDP drivers handling XDP_ABORTED and XDP
> invalid as XDP_DROP.
> Please note this patch has just compile tested.
> 
> Fixes: 06059a1a9a4a5 ("octeontx2-pf: Add XDP support to netdev PF")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

The patch LGTM, but I would appreciate some feedback from someone that
could actually run the code on real H/W before sending it all the way to
stable.

Thanks!

Paolo

Re: [PATCH net] net: octeontx2: Handle XDP_ABORTED and XDP invalid as XDP_DROP

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 01 Apr 2025 11:02:12 +0200 you wrote:
> In the current implementation octeontx2 manages XDP_ABORTED and XDP
> invalid as XDP_PASS forwarding the skb to the networking stack.
> Align the behaviour to other XDP drivers handling XDP_ABORTED and XDP
> invalid as XDP_DROP.
> Please note this patch has just compile tested.
> 
> Fixes: 06059a1a9a4a5 ("octeontx2-pf: Add XDP support to netdev PF")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] net: octeontx2: Handle XDP_ABORTED and XDP invalid as XDP_DROP
    https://git.kernel.org/netdev/net/c/2a8377720a0a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html