BPF List
 help / color / mirror / Atom feed
* [PATCH net-next] netlink: specs: netdev: update doc for xsk tx-checksum and zc-max-segs
@ 2026-09-16  2:16 Jakub Kicinski
  2026-09-18  0:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2026-09-16  2:16 UTC (permalink / raw)
  To: davem
  Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
	donald.hunter, ast, daniel, hawk, john.fastabend, sdf, razor, dw,
	bpf

Minor touch ups to the XSK-related doc strings in the netdev spec.

Tx checksum is (obviously?) Layer 4 (TCP/UDP), not Layer 3 (IP).

The xdp_zc_max_segs change is more subtle, I guess, but to kernel devs
saying "frags" may sound like the number of skb frags. The value includes
the head in this case. The default of 1 means single buffer, XDP_USE_SG
sockets are refused when it is 1. Let's use the word "buffer" instead
of "frag".

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: ast@kernel.org
CC: daniel@iogearbox.net
CC: hawk@kernel.org
CC: john.fastabend@gmail.com
CC: sdf@fomichev.me
CC: razor@blackwall.org
CC: dw@davidwei.uk
CC: bpf@vger.kernel.org
---
 Documentation/netlink/specs/netdev.yaml | 5 +++--
 include/uapi/linux/netdev.h             | 2 +-
 tools/include/uapi/linux/netdev.h       | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index 3e3f03bd5c29..e13461cf3fc3 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -80,7 +80,7 @@ doc: >-
       -
         name: tx-checksum
         doc: >-
-          L3 checksum HW offload is supported by the driver.
+          L4 checksum HW offload is supported by the driver.
       -
         name: tx-launch-time-fifo
         doc: >-
@@ -118,7 +118,8 @@ doc: >-
         enum: xdp-act
       -
         name: xdp-zc-max-segs
-        doc: max fragment count supported by ZC driver
+        doc: max buffer count per packet supported by ZC driver,
+             including the head buffer
         type: u32
         checks:
           min: 1
diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h
index 35ff083221c7..9026e0414fbe 100644
--- a/include/uapi/linux/netdev.h
+++ b/include/uapi/linux/netdev.h
@@ -58,7 +58,7 @@ enum netdev_xdp_rx_metadata {
  * enum netdev_xsk_flags
  * @NETDEV_XSK_FLAGS_TX_TIMESTAMP: HW timestamping egress packets is supported
  *   by the driver.
- * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the
+ * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L4 checksum HW offload is supported by the
  *   driver.
  * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported
  *   by the driver.
diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
index 35ff083221c7..9026e0414fbe 100644
--- a/tools/include/uapi/linux/netdev.h
+++ b/tools/include/uapi/linux/netdev.h
@@ -58,7 +58,7 @@ enum netdev_xdp_rx_metadata {
  * enum netdev_xsk_flags
  * @NETDEV_XSK_FLAGS_TX_TIMESTAMP: HW timestamping egress packets is supported
  *   by the driver.
- * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the
+ * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L4 checksum HW offload is supported by the
  *   driver.
  * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported
  *   by the driver.
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] netlink: specs: netdev: update doc for xsk tx-checksum and zc-max-segs
  2026-09-16  2:16 [PATCH net-next] netlink: specs: netdev: update doc for xsk tx-checksum and zc-max-segs Jakub Kicinski
@ 2026-09-18  0:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-18  0:00 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
	donald.hunter, ast, daniel, hawk, john.fastabend, sdf, razor, dw,
	bpf

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 15 Sep 2026 19:16:08 -0700 you wrote:
> Minor touch ups to the XSK-related doc strings in the netdev spec.
> 
> Tx checksum is (obviously?) Layer 4 (TCP/UDP), not Layer 3 (IP).
> 
> The xdp_zc_max_segs change is more subtle, I guess, but to kernel devs
> saying "frags" may sound like the number of skb frags. The value includes
> the head in this case. The default of 1 means single buffer, XDP_USE_SG
> sockets are refused when it is 1. Let's use the word "buffer" instead
> of "frag".
> 
> [...]

Here is the summary with links:
  - [net-next] netlink: specs: netdev: update doc for xsk tx-checksum and zc-max-segs
    https://git.kernel.org/netdev/net-next/c/8050e0efd4cf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-18  0:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16  2:16 [PATCH net-next] netlink: specs: netdev: update doc for xsk tx-checksum and zc-max-segs Jakub Kicinski
2026-09-18  0:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox