From: Daniel Borkmann <daniel@iogearbox.net>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: bpf@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] BPF: Disable on PREEMPT_RT
Date: Thu, 17 Oct 2019 16:53:58 +0200 [thread overview]
Message-ID: <20191017145358.GA26267@pc-63.home> (raw)
In-Reply-To: <20191017090500.ienqyium2phkxpdo@linutronix.de>
On Thu, Oct 17, 2019 at 11:05:01AM +0200, Sebastian Andrzej Siewior wrote:
> Disable BPF on PREEMPT_RT because
> - it allocates and frees memory in atomic context
> - it uses up_read_non_owner()
> - BPF_PROG_RUN() expects to be invoked in non-preemptible context
For the latter you'd also need to disable seccomp-BPF and everything
cBPF related as they are /all/ invoked via BPF_PROG_RUN() ...
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>
> I tried to fix the memory allocations in
> http://lkml.kernel.org/r/20190410143025.11997-1-bigeasy@linutronix.de
>
> but I have no idea how to address the other two issues.
>
> init/Kconfig | 1 +
> net/kcm/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1629,6 +1629,7 @@ config KALLSYMS_BASE_RELATIVE
> # syscall, maps, verifier
> config BPF_SYSCALL
> bool "Enable bpf() system call"
> + depends on !PREEMPT_RT
> select BPF
> select IRQ_WORK
> default n
> --- a/net/kcm/Kconfig
> +++ b/net/kcm/Kconfig
> @@ -3,6 +3,7 @@
> config AF_KCM
> tristate "KCM sockets"
> depends on INET
> + depends on !PREEMPT_RT
> select BPF_SYSCALL
> select STREAM_PARSER
> ---help---
next prev parent reply other threads:[~2019-10-17 14:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:05 [PATCH] BPF: Disable on PREEMPT_RT Sebastian Andrzej Siewior
2019-10-17 14:53 ` Daniel Borkmann [this message]
2019-10-17 15:40 ` Sebastian Andrzej Siewior
2019-10-17 17:25 ` David Miller
2019-10-17 21:54 ` Thomas Gleixner
2019-10-17 22:13 ` David Miller
2019-10-17 23:50 ` Thomas Gleixner
2019-10-17 23:27 ` Alexei Starovoitov
2019-10-18 0:22 ` Thomas Gleixner
2019-10-18 5:52 ` Alexei Starovoitov
2019-10-18 11:28 ` Thomas Gleixner
2019-10-18 12:48 ` Sebastian Sewior
2019-10-18 23:05 ` Alexei Starovoitov
2019-10-20 9:06 ` Thomas Gleixner
2019-10-22 1:43 ` Alexei Starovoitov
2019-10-18 2:49 ` Clark Williams
2019-10-18 4:57 ` David Miller
2019-10-18 5:54 ` Alexei Starovoitov
2019-10-18 8:38 ` Thomas Gleixner
2019-10-18 12:49 ` Clark Williams
2019-10-18 8:46 ` Thomas Gleixner
2019-10-18 12:43 ` Sebastian Sewior
2019-10-18 12:58 ` Clark Williams
2019-10-17 22:11 ` Thomas Gleixner
2019-10-17 22:23 ` David Miller
2019-10-17 17:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017145358.GA26267@pc-63.home \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=kafai@fb.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox